Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): v2 pod controller errors for acl deletion #3172

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix(controller): v2 pod controller errors for acl deletion #3172

merged 2 commits into from
Nov 7, 2023

Conversation

DanStough
Copy link
Contributor

Changes proposed in this PR:

  • Don't error out if a token is missing metadata.
  • Make sure dataplane is injected with the correct metadata so that the ACL token is created with metadata on login.
  • Explicitly call stop when in the init container when re-direction is enabled.

How I've tested this PR: manual K8S testing plus unit tests.

How I expect reviewers to test this PR: 👁️ 👃 👁️

Checklist:

@DanStough DanStough force-pushed the dans/NET-6298/v2-token-cleanup-errors branch from 3cb435f to 5a08469 Compare November 3, 2023 21:28
thisisnotashwin
thisisnotashwin approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@DanStough DanStough force-pushed the dans/NET-6298/v2-token-cleanup-errors branch from 5a08469 to 8f23c90 Compare November 7, 2023 16:17
@DanStough DanStough enabled auto-merge (squash) November 7, 2023 16:28
@DanStough DanStough merged commit cd79533 into main Nov 7, 2023
24 of 48 checks passed
@DanStough DanStough deleted the dans/NET-6298/v2-token-cleanup-errors branch November 7, 2023 16:51
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Nov 7, 2023
Merged
2 tasks
@zalimeni zalimeni mentioned this pull request Nov 8, 2023
Merged
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
@DanStough @sarahalsmiller
fix(controller): v2 pod controller errors for acl deletion (#3172)
9bbdb84 
* fix(controller): v2 pod controller errors for acl deletion

* test: fix tests for unsupported L7 TPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
backport/1.3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanStough @thisisnotashwin