Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"retryOn" configuration on ServiceRouter CRD #3207

Closed
mr-miles opened this issue Nov 11, 2023 · 1 comment · Fixed by #3308
Closed

"retryOn" configuration on ServiceRouter CRD #3207

mr-miles opened this issue Nov 11, 2023 · 1 comment · Fixed by #3308
Labels
type/bug Something isn't working

Comments

@mr-miles
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

I set the retryOn field in a service-router crd. The field is specified here:
https://developer.hashicorp.com/consul/docs/v1.16.x/connect/config-entries/service-router#routes-destination-retryon

When I queried k8s for the object, the field was not present. It looks like the crds don't match:
https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/templates/crd-servicerouters.yaml#L151

Github search also pulled up an open PR from June:
#2435

Expected behavior

I expected the fields to be set and used in sidecar config, as per the consul docs.

Environment details

EKS 1.27
Consul 1.16.3
Consul-k8s: 1.2.3

@mr-miles mr-miles added the type/bug Something isn't working label Nov 11, 2023
@david-yu
Copy link
Contributor

Thanks for calling this out. This is a consequence of this PR hashicorp/consul#12890 only being merged in core by another contributor. So technically this is inaccurate: https://developer.hashicorp.com/consul/docs/v1.16.x/connect/config-entries/service-router#spec-routes-destination-retryon. This CRD config needs to be added to the ServiceRouter CRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants