Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-6617] security: Bump github.com/golang-jwt/jwt/v4 to 4.5.0 #3237

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Nov 21, 2023

This version is accepted by Prisma/Twistlock, resolving scan results for issue PRISMA-2022-0270. Chosen over later versions to avoid a major version with breaking changes that is otherwise unnecessary.

Note that in practice this is a false positive (see golang-jwt/jwt#258), but we should update the version to aid customers relying on scanners that flag it.

c.f. Consul change here: hashicorp/consul#19705

Changes proposed in this PR:

  • Resolves proprietary scanner reported vulnerability.

I've reviewed the changelog from 4.2.0 to 4.5.0 and don't see any evidence of breaking changes.

How I've tested this PR: Unit tests

How I expect reviewers to test this PR: 👀

Checklist:

@zalimeni zalimeni added backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x labels Nov 21, 2023
This version is accepted by Prisma/Twistlock, resolving scan results for
issue PRISMA-2022-0270. Chosen over later versions to avoid a major
version with breaking changes that is otherwise unnecessary.

Note that in practice this is a false positive (see
golang-jwt/jwt#258), but we should update the
version to aid customers relying on scanners that flag it.
@zalimeni zalimeni force-pushed the zalimeni/net-6617-bump-golang-jwt-prisma branch from f2b7a13 to 908a343 Compare November 21, 2023 16:58
@zalimeni zalimeni requested review from picatz, hashi-derek, a team and curtbushko and removed request for a team November 21, 2023 17:18
@zalimeni zalimeni marked this pull request as ready for review November 21, 2023 17:18
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zalimeni zalimeni merged commit 83a8616 into main Nov 27, 2023
48 checks passed
@zalimeni zalimeni deleted the zalimeni/net-6617-bump-golang-jwt-prisma branch November 27, 2023 15:51
jm96441n pushed a commit that referenced this pull request Nov 29, 2023
security: Bump github.com/golang-jwt/jwt/v4 to 4.5.0

This version is accepted by Prisma/Twistlock, resolving scan results for
issue PRISMA-2022-0270. Chosen over later versions to avoid a major
version with breaking changes that is otherwise unnecessary.

Note that in practice this is a false positive (see
golang-jwt/jwt#258), but we should update the
version to aid customers relying on scanners that flag it.
sarahalsmiller pushed a commit that referenced this pull request Jan 5, 2024
security: Bump github.com/golang-jwt/jwt/v4 to 4.5.0

This version is accepted by Prisma/Twistlock, resolving scan results for
issue PRISMA-2022-0270. Chosen over later versions to avoid a major
version with breaking changes that is otherwise unnecessary.

Note that in practice this is a false positive (see
golang-jwt/jwt#258), but we should update the
version to aid customers relying on scanners that flag it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.1.x Backport to release/1.1.x branch backport/1.2.x This release branch is no longer active. backport/1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants