Add consul.hashicorp.com/proxy-config-map annotation.
#3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an annotation that allows for generically setting data in the opaque config map for proxy service registrations. Use of this annotation is not encouraged in most situations, but it is necessary for certain circumstances. Notably, this new annotation allows users to specify the `xds_fetch_timeout_ms` configuration during service registration, which is sometimes needed by proxies with a large number of upstreams.
hashi-derek
force-pushed
the
derekm/NET-6565/proxy-config-map
branch
from
2049caa
to
015b994
Compare
hashi-derek
added
backport/1.1.x
|
@hashi-derek Could you also add a PR for docs for this new annotation here: https://developer.hashicorp.com/consul/docs/k8s/annotations-and-labels#consul-service-mesh |
thisisnotashwin
approved these changes
Dec 11, 2023
erichaberkorn
approved these changes
Dec 11, 2023
This was referenced Dec 11, 2023
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
This introduces an annotation that allows for generically setting data in the opaque config map for proxy service registrations. Use of this annotation is not encouraged in most situations, but it is necessary for certain circumstances. Notably, this new annotation allows users to specify the `xds_fetch_timeout_ms` configuration during service registration, which is sometimes needed by proxies with a large number of upstreams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an annotation
consul.hashicorp.com/proxy-config-mapthat allows for generically setting data in the opaque config map for proxy service registrations. Use of this annotation is not encouraged in most situations, but it is necessary for certain circumstances.Notably, this new annotation allows users to specify the
xds_fetch_timeout_msconfiguration during service registration, which is sometimes needed by proxies with a large number of upstreams.