Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.yml: package consul-cni #4040

Merged
merged 15 commits into from
May 24, 2024
Merged

build.yml: package consul-cni #4040

merged 15 commits into from
May 24, 2024

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented May 23, 2024 •
edited
Loading

Changes proposed in this PR

  • Only package consul-cni for amd64 and arm64 on linux
  • Added extra step to just package consul-cni, testing is only done for consul-k8s CLI
  • For binary use matrix.bin_name instead of matrix.pkg_name
  • Added skip_packaging to more artifacts to make things more explicit although likely not needed

How I've tested this PR

How I expect reviewers to test this PR

Checklist

@david-yu david-yu requested review from zalimeni and shore May 24, 2024 04:02
zalimeni
zalimeni approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock but have one comment on the matrix checks. Would prefer to get a 👍🏻 from RelEng as well in case I'm missing something.

.github/workflows/build.yml Outdated Show resolved Hide resolved
shore
shore approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@shore shore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

blake
blake reviewed May 24, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@blake
Update .github/workflows/build.yml
8639b1d 
Co-authored-by: Blake Covarrubias <[email protected]>
blake
blake reviewed May 24, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
shore
shore reviewed May 24, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
David Yu and others added 2 commits May 24, 2024 13:07
shore
shore approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@shore shore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

blake
blake requested changes May 24, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
Update build.yml
fffb9b1 
remove solaris, Darwin, and windows for consul-cni builds
@david-yu david-yu enabled auto-merge (squash) May 24, 2024 20:52
@david-yu david-yu merged commit 87de7eb into main May 24, 2024
26 of 50 checks passed
@david-yu david-yu deleted the david-yu-consul-cni branch May 24, 2024 21:06
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request May 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blake blake blake approved these changes

@shore shore shore approved these changes

@zalimeni zalimeni zalimeni approved these changes

Assignees
No one assigned
Labels
backport/1.4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david-yu @blake @shore @zalimeni