sso/oidc: add support for acr_values request parameter #11026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/api
|
🤔 This PR has changes in the |
rboyer
reviewed
Sep 14, 2021
rboyer
reviewed
Sep 14, 2021
rboyer
reviewed
Sep 14, 2021
Co-authored-by: R.B. Boyer <[email protected]>
Co-authored-by: R.B. Boyer <[email protected]>
kyhavlov
approved these changes
Sep 15, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/448927. |
|
🍒✅ Cherry pick of commit c4c833f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Sep 17, 2021
Co-authored-by: R.B. Boyer <[email protected]>
|
🍒✅ Cherry pick of commit c4c833f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Sep 17, 2021
Co-authored-by: R.B. Boyer <[email protected]>
|
🍒✅ Cherry pick of commit c4c833f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Sep 17, 2021
Co-authored-by: R.B. Boyer <[email protected]>
|
🍒✅ Cherry pick of commit c4c833f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Sep 17, 2021
Co-authored-by: R.B. Boyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change for the OSS side that the enterprise side depends on to make
acr_valuesconfigurable on the OAuth2 authorization request [1]. This particular parameter is one of a few optional parameters that were never supported in our core SSO library because there wasn't a use case when it was originally developed. The successor to our SSO library,hashicorp/capdoes support these and the other optional parameters. We may pursue replacing our SSO library withcapbut until then, we need to add this parameter as a stop-gap for a client request.[1] - OIDC Request Parameters