-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KVUsage to consul state usage metrics #11090
Conversation
This change will add the number of entries in the consul KV store to the already existing usage metrics.
This will add information about the new kv_usage metric to the website
🤔 This PR has changes in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from a docs perspective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I left a few comments but they are ultra-nitpicky.
Co-authored-by: Matt Keeler <[email protected]>
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/453132. |
🍒✅ Cherry pick of commit 1e3ba26 onto |
Add KVUsage to consul state usage metrics
Add KVUsage to consul state usage metrics
Backport #11090 into release/1.10.x
@@ -36,6 +36,10 @@ var Gauges = []prometheus.GaugeDefinition{ | |||
Name: []string{"consul", "members", "servers"}, | |||
Help: "Measures the current number of server agents registered with Consul. It is only emitted by Consul servers. Added in v1.9.6.", | |||
}, | |||
{ | |||
Name: []string{"consul", "kv", "entries"}, | |||
Help: "Measures the current number of server agents registered with Consul. It is only emitted by Consul servers. Added in v1.10.3.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Measures the current number of unique KV entries written in Consul. It is only emitted by Consul servers. Added in v1.10.3.
No description provided.