Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Config Entry for registering ExternalServices #12605

Open
barrymars opened this issue Mar 23, 2022 · 5 comments
Open

Provide Config Entry for registering ExternalServices #12605

barrymars opened this issue Mar 23, 2022 · 5 comments
Labels
theme/config Relating to Consul Agent configuration, including reloading type/enhancement Proposed improvement or new feature

Comments

@barrymars
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Implement a CRD for ExternalServices so that they can be defined via Kubernetes Manifests rather than a manual action.

Feature Description

This was mentioned in hashicorp/consul-k8s#201 (hashicorp/consul-k8s#201 (comment)) but not really the same issue.

It's possible to configure the TerminatingGateway via CRD, but the ExternalService itself still needs to be registered manually via the API

@barrymars barrymars added the type/enhancement Proposed improvement or new feature label Mar 23, 2022
@t-eckert
Copy link
Contributor

Hi @barrymars,

Thank you for this suggestion. I will let our PM know and see if it makes sense in our roadmap.

@david-yu
Copy link
Contributor

Hi @barrymars thanks for filing the feature request! I agree registering external services via CRD would be a great improvement in overall UX. First we'd need to create a Config Entry within Consul to handle registering External services. Could you give us an example of how you register services with Consul today that we could perhaps translate to a Config entry?

As a side note, I'm going to transfer this over to the Core backlog and will alert the PMs from the Core side of this feature request.

@david-yu david-yu changed the title Implement CRD for ExternalServices Provide Config Entry for registering ExternalServices Mar 23, 2022
@david-yu david-yu transferred this issue from hashicorp/consul-k8s Mar 23, 2022
@Amier3 Amier3 added theme/kubernetes Consul-helm/kubernetes related questions theme/config Relating to Consul Agent configuration, including reloading labels Mar 23, 2022
@barrymars
Copy link
Author

@david-yu Only working with testing at the moment, so just following examples documented here - https://www.consul.io/docs/k8s/connect/terminating-gateways#register-external-services-with-consul

@barrymars
Copy link
Author

Would be useful if this could also update the "terminating-gateway-token" ACL policy at the same time

@david-yu
Copy link
Contributor

@barrymars This is something we'd like to consider for improving Terminating Gateway UX if we built a Kubernetes Operator for K8s. I do agree that the UX is far from ideal and the ACL piece is usually the most challenging piece. Could you open up a separate issue on the consul-k8s issue to track this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/config Relating to Consul Agent configuration, including reloading type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

4 participants