ui: swap unicode glyph with inline svg for the settings icon #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
settings-icon
branch
from
3a4fd0e
to
1ed16d0
Compare
meirish
force-pushed
the
settings-icon
branch
from
1ed16d0
to
fba54c3
Compare
|
LGTM |
slackpad
added a commit
that referenced
this pull request
Dec 4, 2015
ui: swap unicode glyph with inline svg for the settings icon
|
HI #21198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1467
One screen cap is from Chrome, the other is Safari. The images also show that with the SVG, we can vary the fill so it'll have the active color when you're on the settings page.