Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove v2 tenancy, catalog, and mesh #21592

Merged
merged 5 commits into from
Sep 5, 2024
Merged

remove v2 tenancy, catalog, and mesh #21592

merged 5 commits into from
Sep 5, 2024

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 8, 2024

  • Inline the v2tenancy experiment to false
  • Inline the resource-apis experiment to false
  • Inline the hcp-v2-resource-apis experiment to false
  • Remove ACL policy templates and rule language changes related to workload identities (a v2-only concept) (e.g. identity and identity_prefix)
  • Update the gRPC endpoint used by consul-dataplane to no longer respond specially for v2
  • Remove stray v2 references scattered throughout the DNS v1.5 newer implementation.

Best viewed commit-by-commit, or honestly locally with git diff -D (to skip deleted files). The Big Bad Commit is the catalog/mesh one which had a lot of tendrils to clean up and nuked a lot of files.

- Inline the v2tenancy experiment to false

- Inline the resource-apis experiment to false

- Inline the hcp-v2-resource-apis experiment to false

- Remove ACL policy templates and rule language changes related to
  workload identities (a v2-only concept) (e.g. identity and
  identity_prefix)

- Update the gRPC endpoint used by consul-dataplane to no longer respond
  specially for v2

- Remove stray v2 references scattered throughout the DNS v1.5 newer
  implementation.
@rboyer rboyer self-assigned this Aug 8, 2024
@rboyer rboyer requested a review from a team as a code owner August 8, 2024 20:52
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support labels Aug 8, 2024
@jmurret jmurret merged commit 3e6f1c1 into main Sep 5, 2024
91 checks passed
@jmurret jmurret deleted the rboyer/remove-v2 branch September 5, 2024 14:50
philrenaud pushed a commit that referenced this pull request Sep 12, 2024
* remove v2 tenancy, catalog, and mesh

- Inline the v2tenancy experiment to false

- Inline the resource-apis experiment to false

- Inline the hcp-v2-resource-apis experiment to false

- Remove ACL policy templates and rule language changes related to
  workload identities (a v2-only concept) (e.g. identity and
  identity_prefix)

- Update the gRPC endpoint used by consul-dataplane to no longer respond
  specially for v2

- Remove stray v2 references scattered throughout the DNS v1.5 newer
  implementation.

* changelog

* go mod tidy on consul containers

* lint fixes from ENT

---------

Co-authored-by: John Murret <[email protected]>
@zalimeni
Copy link
Member

@jmurret @rboyer WDYT about backporting this through 1.18 LTS (also now the oldest version w/ v2 code)? Ran into some more golden test breakage today, and though we could surgically cut that part out, backports to affected code will be easier if we push this down, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/dependencies PR specifically updates dependencies of project pr/no-backport pr/no-metrics-test theme/acls ACL and token generation theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/envoy/xds Related to Envoy support theme/health-checks Health Check functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants