-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove v2 tenancy, catalog, and mesh #21592
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inline the v2tenancy experiment to false - Inline the resource-apis experiment to false - Inline the hcp-v2-resource-apis experiment to false - Remove ACL policy templates and rule language changes related to workload identities (a v2-only concept) (e.g. identity and identity_prefix) - Update the gRPC endpoint used by consul-dataplane to no longer respond specially for v2 - Remove stray v2 references scattered throughout the DNS v1.5 newer implementation.
github-actions
bot
added
theme/api
Relating to the HTTP API interface
theme/health-checks
Health Check functionality
theme/acls
ACL and token generation
theme/cli
Flags and documentation for the CLI interface
theme/config
Relating to Consul Agent configuration, including reloading
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
pr/dependencies
PR specifically updates dependencies of project
theme/envoy/xds
Related to Envoy support
labels
Aug 8, 2024
jmurret
approved these changes
Sep 4, 2024
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
* remove v2 tenancy, catalog, and mesh - Inline the v2tenancy experiment to false - Inline the resource-apis experiment to false - Inline the hcp-v2-resource-apis experiment to false - Remove ACL policy templates and rule language changes related to workload identities (a v2-only concept) (e.g. identity and identity_prefix) - Update the gRPC endpoint used by consul-dataplane to no longer respond specially for v2 - Remove stray v2 references scattered throughout the DNS v1.5 newer implementation. * changelog * go mod tidy on consul containers * lint fixes from ENT --------- Co-authored-by: John Murret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/dependencies
PR specifically updates dependencies of project
pr/no-backport
pr/no-metrics-test
theme/acls
ACL and token generation
theme/api
Relating to the HTTP API interface
theme/cli
Flags and documentation for the CLI interface
theme/config
Relating to Consul Agent configuration, including reloading
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
theme/envoy/xds
Related to Envoy support
theme/health-checks
Health Check functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2tenancy
experiment tofalse
resource-apis
experiment tofalse
hcp-v2-resource-apis
experiment tofalse
identity
andidentity_prefix
)Best viewed commit-by-commit, or honestly locally with
git diff -D
(to skip deleted files). The Big Bad Commit is the catalog/mesh one which had a lot of tendrils to clean up and nuked a lot of files.