Deprecate configtest and add validate command #2732
Conversation
|
LGTM with one addition - missed the success message and |
|
LGTM |
| var quiet bool | ||
|
|
||
| f := c.Command.NewFlagSet(c) | ||
| f.Var((*agent.AppendSliceValue)(&configFiles), "config-file", |
There was a problem hiding this comment.
@kyhavlov I still think it'd be a better UX to just accept one option here and determine if it's a file or folder appropriately. I don't see a reason why we need to treat them separately.
There was a problem hiding this comment.
I left those in as hidden flags to stay compatible with configtest; everything (args, -config-file, config-dir) gets added to configFiles which works with files or directories. Do you think we should just remove the flags from validate altogether?
There was a problem hiding this comment.
Ah sorry. I didn't see the "hidden" call below. +1 to BC! Great work on this and sorry for the confusion
|
consul validate seem to fail is there's no 'data_dir' in the config file even though you could just use a cli option to provide that parameter. |
Hides the configtest command, adds a deprecation notice, and adds the validate command with the old configtest flags as hidden flags.
Closes #2421