Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: un-deprecate api.DecodeConfigEntry #6278

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 5, 2019

Add clarifying commentary about when it is not safe to use it. Also add tests.

Add clarifying commentary about when it is not safe to use it. Also add
tests.
@rboyer rboyer added this to the 1.6.0-rc1 milestone Aug 5, 2019
@rboyer rboyer requested a review from a team August 5, 2019 21:17
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rboyer rboyer merged commit 9753c77 into release/1-6 Aug 5, 2019
@rboyer rboyer deleted the un-deprecate-api-decode-config-entry branch August 5, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants