connect: add toggle to globally disable wildcard outbound network access when transparent proxy is enabled #9973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess when transparent proxy is enabled This adds a new config entry kind "cluster" with a single special name "cluster where this can be controlled.
github-actions
bot
added
theme/api
rboyer
commented
Apr 6, 2021
| @@ -0,0 +1,5 @@ | |||
| package structs | |||
|
|
|||
| func (e *ClusterConfigEntry) validateEnterpriseMeta() error { | |||
There was a problem hiding this comment.
The enterprise version of this method will be lifted from the current version of ProxyConfigEntry
freddygv
approved these changes
Apr 6, 2021
| "github.com/mitchellh/copystructure" | ||
|
|
||
| "github.com/hashicorp/consul/agent/structs" |
There was a problem hiding this comment.
Yeah I picked this tweak up from @dnephin for invoking goimports:
let g:go_fmt_options = {
\ 'goimports': '-local github.com/hashicorp/consul',
\ }
Comment on lines
+12
to
+13
| testinf "github.com/mitchellh/go-testing-interface" | ||
| "github.com/stretchr/testify/require" |
| @@ -8,11 +8,12 @@ import ( | |||
|
|
|||
| "github.com/hashicorp/consul/agent/structs" | |||
|
|
|||
| "github.com/mitchellh/cli" | |||
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/345785. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config entry kind "cluster" with a single special name "cluster" where this can be controlled.
TODO