Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped quotes not handled correctly by parser #35

Closed
apparentlymart opened this issue Nov 19, 2016 · 2 comments · Fixed by #36
Closed

Escaped quotes not handled correctly by parser #35

apparentlymart opened this issue Nov 19, 2016 · 2 comments · Fixed by #36

Comments

@apparentlymart
Copy link
Contributor

In the new hand-written scanner/parser, the scanner is correctly handling escaped quotes in quoted sequences -- ensuring that they don't prematurely terminate the string token -- but the parser is missing the rule to replace an escaped quote with a literal quote.

This was reported in hashicorp/terraform#10236 .

@mitchellh
Copy link
Contributor

Note that some BC here is to be expected due to this: hashicorp/hcl#150

@apparentlymart
Copy link
Contributor Author

Ahh... I had a feeling something had changed somewhere else that had made this behavior different, since I didn't recall seeing this escaped quote handling in the old parser. Glad to see that there's a corresponding HCL change that explains that. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants