Adds version output parsing

[paultyng]

No description provided.

[radeksimko]

I think the note could be suppressed by disabling checkpoint when running under test, which would make the tests less fragile.

[radeksimko]

And perhaps we should even disable checkpoint for version commands by default as the advice is ignored and it's not shown to the end-user anyway?

[kmoe]

Couple of comments and trivial merge conflict.

This PR can be a test of #12 once CI is set up - then it can land in v0.2.0.

Thanks!

[kmoe]

I think Version() should always invoke terraform version - tfexec is intended as a way to invoke terraform CLI commands as transparently as possible.

If the consumer wants the cached versions, they can read the fields from the Terraform struct.

[radeksimko]

I agree with Katy here, I think that any caching responsibility should be up to the consumer, even if it's consumer within terraform-exec itself. e.g. I assume at some point we may need to cache and/or transparently expose the version here

terraform-exec/tfinstall/tfinstall.go

Lines 133 to 136 in 22dfd35

	err := runTerraformVersion(terraformPath)
	if err != nil {
	return "", fmt.Errorf("executable found at path %s is not terraform: %s", terraformPath, err)
	}

but any such caching/exposure decision should be made within that package, keeping tfexec itself simple and transparent.

[paultyng]

Yeah I agree (about re-invocation at least, I dislike a field for this, will put a new commit together with thoughts).

Especially now that this is more info than just the tf version (provider versions), re-invocation is much more useful.

[paultyng]

Rebased and pulled in your work in #16

[paultyng]

@kmoe rebased and added runtime tests for 0.11, 0.12, and 0.13.

[paultyng]

The wintest failure is Go 1.12 it seems.

[kmoe]

Yes, the Windows executor is using Go 1.12. It seems it's not happy with the use of %w.

[kmoe]

Please rebase following #37. Once CI passes we can merge.

[paultyng]

All 🟢!