-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Add support for embedded struct types in object conversions #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
SBGoods
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Austin! Just one comment about empty struct tags.
SBGoods
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
Previous proposals: #941, #667
This PR introduces support for
types.Object
conversions with Go structs that utilize struct embedding:This PR supports N levels of nested embedded struct types and applies the same
tfsdk
tag restrictions/validations regardless of where the tag appears in the struct.Example
The same example schema could also be represented by these model combinations:
Notes
tfsdk
tags in framework providers terraform-provider-corner#263encoding/json
library supports exported struct embedding via pointers, but it was also historically relying on a bug in Go that allowed setting unexported struct embedding with pointers to work. When that bug was fixed, they chose not to completely remove pointer struct embedding for compatibility reasons.tfsdk
ignore tags are not included