Allow using ValueAs into attr.Value. #232
Conversation
Allow for generic handling of attr.Values by special-casing ValueAs (and, consequently, GetAttribute) to bypass reflection when we want to just obtain the raw attr.Value.
There was a problem hiding this comment.
Looks good to me 🚀
I'd love to unit test this to match the CHANGELOG entry since we have expectations for what is to occur "at a distance", but it would not be a trivial inclusion. e.g. adding the below test case to TestStateGetAttribute
"attr.Value": {
state: State{
Raw: tftypes.NewValue(tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"name": tftypes.String,
},
}, map[string]tftypes.Value{
"name": tftypes.NewValue(tftypes.String, "namevalue"),
}),
Schema: Schema{
Attributes: map[string]Attribute{
"name": {
Type: types.StringType,
Required: true,
},
},
},
},
target: new(attr.Value),
expected: &types.String{Value: "namevalue"},
},Yields:
--- FAIL: TestStateGetAttribute (0.00s)
--- FAIL: TestStateGetAttribute/attr.Value (0.00s)
/Users/bflad/src/github.com/hashicorp/terraform-plugin-framework/tfsdk/state_test.go:1070: unexpected value (+wanted, -got): interface{}(
- &⟪0xc00020ffb0⟫"github.com/hashicorp/terraform-plugin-framework/types".String{Value: "namevalue"},
+ &⟪0xc00020c7f8⟫"github.com/hashicorp/terraform-plugin-framework/types".String{Value: "namevalue"},
)
Because the types.String Equal method is implemented as a value receiver and not as a pointer receiver. Semi-relates to proposal 2 of #201 and #221.
|
Yeah, I think that's what I found. Which is a bummer. Need to think about how to do that properly.... :( |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Allow for generic handling of attr.Values by special-casing ValueAs
(and, consequently, GetAttribute) to bypass reflection when we want to
just obtain the raw attr.Value.
Fixes #230.