Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfsdk: Remove empty schema restriction #252

Merged
merged 1 commit into from
Jan 25, 2022
Merged

tfsdk: Remove empty schema restriction #252

merged 1 commit into from
Jan 25, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 25, 2022

Closes #250

This restriction does not seem necessary. Updated unit test and also real world verified against Terraform CLI with a test provider.

@bflad
tfsdk: Remove empty schema restriction
1cd86a3 
Reference: #250

This restriction does not seem necessary. Updated unit test and also real world verified against Terraform CLI with a test provider.
@bflad bflad added bug Something isn't working schema Issues and pull requests about the abstraction for specifying schemas. labels Jan 25, 2022
@bflad bflad added this to the v0.6.0 milestone Jan 25, 2022
@bflad bflad mentioned this pull request Jan 25, 2022
Closed
appilon
appilon approved these changes Jan 25, 2022
View reviewed changes
Copy link

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 60d5cd8 into main Jan 25, 2022
@bflad bflad deleted the bflad-remove-schema-count-error branch January 25, 2022 18:22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working schema Issues and pull requests about the abstraction for specifying schemas.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Can't have empty provider block schema
2 participants
@bflad @appilon