Provider, Resource, and DataSource types #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
suggested changes
Jun 1, 2021
data_source.go
Outdated
| ) | ||
|
|
||
| // A DataSourceType is a type of data source. For each type of data source this | ||
| // provider supports, it should instantiate a struct implementing DataSourceType |
There was a problem hiding this comment.
Suggested change
| // provider supports, it should instantiate a struct implementing DataSourceType | |
| // provider supports, it should define a type implementing DataSourceType |
There was a problem hiding this comment.
If we clarify in this direction, I'd rather we change the whole thing to "it should define a type implementing DataSourceType and return an instance [of that type] in the map returned by Provider.GetDataSources." Will do so and we can see if it reads better.
resource.go
Outdated
| ) | ||
|
|
||
| // A ResourceType is a type of resource. For each type of resource this provider | ||
| // supports, it should instantiate a struct implementing ResourceType and return |
There was a problem hiding this comment.
Suggested change
| // supports, it should instantiate a struct implementing ResourceType and return | |
| // supports, it should define a type implementing ResourceType and return |
paddycarver
added a commit
that referenced
this pull request
Jun 2, 2021
paddycarver
added a commit
that referenced
this pull request
Jun 2, 2021
paddycarver
added a commit
that referenced
this pull request
Jun 2, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
closes #15