internal/toproto*: Convert null list/set block values to empty #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #604 Reference: #620 This logic implements the inverse of what was added to `internal/fromproto*` where empty block values are converted to null. While Terraform implements some logic to automatically convert these for state responses from `ReadResource` and others, the same null values can cause errors with Terraform's plan validity logic. This fixes the potential new error caused by only introducing the `internal/fromproto*` logic, which was not released and why it does not contain a changelog entry in that regard, However, this change is considered an overall enhancement prior and including those changes since it means the provider developers will no longer be burdened with understanding Terraform's implementation details with null versus empty collection blocks when setting values for responses.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #604
Closes #620
This logic implements the inverse of what was added to
internal/fromproto*where empty block values are converted to null. While Terraform implements some logic to automatically convert these for state responses fromReadResourceand others, the same null values can cause errors with Terraform's plan validity logic.This fixes the potential new error caused by only introducing the
internal/fromproto*logic, which was not released and why it does not contain a changelog entry in that regard, However, this change is considered an overall enhancement prior and including those changes since it means the provider developers will no longer be burdened with understanding Terraform's implementation details with null versus empty collection blocks when setting values for responses.