Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SchemaValidateDiagFunc variants of helper/validation All and Any #780

Closed
ewbankkit opened this issue Jul 7, 2021 · 2 comments · Fixed by #1155
Closed

Add SchemaValidateDiagFunc variants of helper/validation All and Any #780

ewbankkit opened this issue Jul 7, 2021 · 2 comments · Fixed by #1155
Assignees
@bflad
Labels
enhancement New feature or request
Milestone
v2.29.0

Comments

@ewbankkit
Copy link
Contributor

SDK version

% go list -m github.com/hashicorp/terraform-plugin-sdk/...
github.com/hashicorp/terraform-plugin-sdk/v2 v2.7.0

Use-cases

To facilitate the migration from classic SchemaValidateFunc validators to new SchemaValidateDiagFunc validators it would be handy to have variants of the All and Any meta-validators that support the new validator function type.
@ewbankkit ewbankkit added the enhancement New feature or request label Jul 7, 2021
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Jan 5, 2022 •
edited
Loading

Note to future self.
The Terraform AWS Provider has local implementations of some of this functionality which can be replaced once this is implemented:

find . -name '*.go' -print | xargs grep issues/780

@ewbankkit ewbankkit mentioned this issue Sep 29, 2022
Closed
@kangasta kangasta mentioned this issue Feb 21, 2023
Merged
@bflad bflad added this to the v2.29.0 milestone Aug 29, 2023
@bflad bflad self-assigned this Aug 29, 2023
@bflad bflad linked a pull request Aug 29, 2023 that will close this issue
Add AllDiag and AnyDiag to helper/validation for combining SchemaValidateDiagFunc #1155
Merged
bflad pushed a commit that referenced this issue Aug 29, 2023
@kangasta
helper/validation: Add AllDiag and AnyDiag for combining `SchemaV…
49fb1ee 
…alidateDiagFunc` (#1155)

Reference: #780
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.29.0
2 participants
@bflad @ewbankkit