Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: r/aws_cloudformation_stack: Use new 'waitForCloudFormationStackXXX' functions #10034

Closed
ewbankkit opened this issue Sep 6, 2019 · 4 comments
Closed

Tech debt: r/aws_cloudformation_stack: Use new 'waitForCloudFormationStackXXX' functions #10034

ewbankkit opened this issue Sep 6, 2019 · 4 comments
Assignees
@YakDriver
Labels
service/cloudformation Issues and PRs that pertain to the cloudformation service. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 6, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

#7342 added new functions to consistently check that a CloudFormation Stack reaches a desired state.
These functions can now be used in the aws_cloudformation_stack resource code:

  • waitForCloudFormationStackCreation in resourceAwsCloudFormationStackCreate
  • waitForCloudFormationStackDeletion in resourceAwsCloudFormationStackDelete

and additionally for resourceAwsCloudFormationStackUpdate.

New or Affected Resource(s)

  • aws_cloudformation_stack

Potential Terraform Configuration

n/a

References
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 6, 2019
@ghost ghost added the service/cloudformation Issues and PRs that pertain to the cloudformation service. label Sep 6, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2019
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2019
@teraken0509 teraken0509 mentioned this issue Sep 17, 2019
Closed
@ewbankkit
Copy link
Contributor Author

Can now refactor to separate waiters package: #12840.

@bflad
Copy link
Contributor

bflad commented Nov 23, 2020

I believe this may have been covered by recent changes here? #15989

@ewbankkit
Copy link
Contributor Author

Yes, #15989 addressed this.

@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
@YakDriver YakDriver assigned YakDriver and unassigned gdavison Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YakDriver YakDriver

Labels
service/cloudformation Issues and PRs that pertain to the cloudformation service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor aws_cloudformation_stack resource teraken0509/terraform-provider-aws
4 participants
@bflad @gdavison @ewbankkit @YakDriver