Adding support for error_output_prefix to the aws_kinesis_firehose_delivery_stream s3 destination #11229

JeffAshton · 2019-12-10T21:16:00Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7997
Relates #7953
Release note for CHANGELOG:

resource/aws_kinesis_firehose_delivery_stream: Add s3_configuration error_output_prefix argument (#7997)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKinesisFirehoseDeliveryStream'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSKinesisFirehoseDeliveryStream -timeout 120m
go: downloading github.com/hashicorp/vault v0.10.4
go: downloading github.com/pquerna/otp v1.2.0
go: extracting github.com/pquerna/otp v1.2.0
go: downloading github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
go: extracting github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
go: extracting github.com/hashicorp/vault v0.10.4
go: finding github.com/hashicorp/vault v0.10.4
go: finding github.com/pquerna/otp v1.2.0
go: finding github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_basic
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_basic
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basic
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3basic
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithPrefixes
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithPrefixes
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
=== PAUSE TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_basic
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithPrefixes
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (79.05s)
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_HiveJsonSerDe_Empty (101.90s)
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_ParquetSerDe_Empty (106.31s)
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_s3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (111.29s)
=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OpenXJsonSerDe_Empty (116.11s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (116.40s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_basic (122.69s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ExternalUpdate (129.52s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Deserializer_Update (131.89s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Serializer_Update (141.54s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (141.67s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (144.76s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (147.74s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_Enabled (152.12s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_ErrorOutputPrefix (157.45s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (167.09s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithPrefixes (177.20s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (104.46s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithTags (153.69s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (232.92s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3_DataFormatConversionConfiguration_OrcSerDe_Empty (128.39s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basicWithSSE (252.23s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (738.16s)
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (868.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       868.335s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.001s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.026s [no tests to run]

JeffAshton · 2019-12-10T21:18:17Z

aws/resource_aws_kinesis_firehose_delivery_stream.go

@@ -1378,7 +1384,7 @@ func createSourceConfig(source map[string]interface{}) *firehose.KinesisStreamSo
 	return configuration
 }

-func createS3Config(d *schema.ResourceData) *firehose.S3DestinationConfiguration {
+func createS3Config(d *schema.ResourceData, withErrorOutputPrefix bool) *firehose.S3DestinationConfiguration {


s3/elasticsearch/splunk support ErrorOutputPrefix, however, redshift does not

aws/resource_aws_kinesis_firehose_delivery_stream.go

JeffAshton · 2019-12-10T21:20:26Z

aws/resource_aws_kinesis_firehose_delivery_stream.go

@@ -1835,6 +1851,8 @@ func createRedshiftConfig(d *schema.ResourceData, s3Config *firehose.S3Destinati

 	redshift := rl[0].(map[string]interface{})

+	s3Config := createS3Config(d, false)


Redshift does not support the ErrorOutputPrefix, so false is passed. I moved the s3 config construction into each of the destination config methods to reflect they don't share the same s3 config.

aws/resource_aws_kinesis_firehose_delivery_stream_test.go

ewbankkit · 2021-04-28T13:18:31Z

zhelding · 2021-10-19T16:46:27Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

JeffAshton · 2021-10-19T17:00:24Z

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@zhelding, I'm happy to update the PR, but will it sit for another 2 years without action?

zhelding · 2021-11-04T17:50:41Z

Hi @JeffAshton. No further action is required on your end for merging this pull request.

This pull request will now be addressed via our standard prioritization process. Unfortunately, given the large quantity of issues and pull requests we receive, we are not always able to review every pull request in a timely manner.

We prioritize contributions that provide the greatest value to the largest number of users -- which we primarily infer based on the number of 👍 reactions. Additionally, an explanation of the particular use case for a contribution can provide information on how the changes might be useful in a broader context.

You can get a view of the wider development plans for the provider via our road map, published quarterly.

Thank you again for your contribution and your patience.

…ut_prefix

anGie44 · 2021-12-23T21:35:05Z

Output of acceptance tests (commercial):

--- PASS: TestAccFirehoseDeliveryStream_Elasticsearch_ErrorOutputPrefix (1018.23s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionDeserializer_update (243.45s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionHiveJSONSerDe_empty (157.07s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOpenXJSONSerDe_empty (228.29s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionOrcSerDe_empty (225.64s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionParquetSerDe_empty (148.23s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversionSerializer_update (225.51s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3DataFormatConversion_enabled (216.74s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3Processing_empty (133.66s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_S3BackupConfiguration_ErrorOutputPrefix (172.96s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_errorOutputPrefix (191.00s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_externalUpdate (183.81s)
--- PASS: TestAccFirehoseDeliveryStream_ExtendedS3_kinesisStreamSource (69.63s)
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_ErrorOutputPrefix (192.50s)
--- PASS: TestAccFirehoseDeliveryStream_HTTPEndpoint_retryDuration (137.78s)
--- PASS: TestAccFirehoseDeliveryStream_Splunk_ErrorOutputPrefix (181.97s)
--- PASS: TestAccFirehoseDeliveryStream_basic (213.39s)
--- PASS: TestAccFirehoseDeliveryStream_disappears (178.52s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchEndpointUpdates (972.00s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchUpdates (1214.49s)
--- PASS: TestAccFirehoseDeliveryStream_elasticSearchWithVPCUpdates (2893.99s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (174.81s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (134.56s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (241.41s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (216.54s)
--- PASS: TestAccFirehoseDeliveryStream_httpEndpoint (191.78s)
--- PASS: TestAccFirehoseDeliveryStream_missingProcessing (151.60s)
--- PASS: TestAccFirehoseDeliveryStream_redshiftUpdates (367.96s)
--- PASS: TestAccFirehoseDeliveryStream_s3KinesisStreamSource (84.78s)
--- PASS: TestAccFirehoseDeliveryStream_s3Updates (214.43s)
--- PASS: TestAccFirehoseDeliveryStream_s3WithCloudWatchLogging (154.28s)
--- PASS: TestAccFirehoseDeliveryStream_s3basic (165.58s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithPrefixes (243.23s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSE (413.80s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyARN (327.52s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithSSEAndKeyType (326.34s)
--- PASS: TestAccFirehoseDeliveryStream_s3basicWithTags (249.49s)
--- PASS: TestAccFirehoseDeliveryStream_splunkUpdates (182.40s)

anGie44

Hi @JeffAshton , thank you so much for this PR and apologies for the wait! Overall, looked great 👍 To get this into our upcoming release, I've added a changelog and some additional tests per destination. Since the S3ConfigurationSchema is also shared by the s3_backup_configuration within redshift_configuration and extended_s3_configuration, i've added support there as well. Lastly, to address the ErrorOutputPrefix handling for redshift, i've moved that outside of the methods we already have to keep that logic closer to where the destination-specific configurations are generated.

github-actions · 2022-01-06T23:56:42Z

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-28T02:28:32Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Adding support for error_output_prefix to s3 destination

c9a9e8e

JeffAshton requested a review from a team December 10, 2019 21:16

JeffAshton commented Dec 10, 2019

View reviewed changes

aws/resource_aws_kinesis_firehose_delivery_stream.go Outdated Show resolved Hide resolved

JeffAshton commented Dec 10, 2019

View reviewed changes

aws/resource_aws_kinesis_firehose_delivery_stream_test.go Outdated Show resolved Hide resolved

Obsecurus mentioned this pull request Feb 26, 2020

r/aws_kinesis_firehose_delivery_stream: Add support for s3 custom prefixes #7953

Closed

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:14

Base automatically changed from master to main January 23, 2021 00:56

breathingdust requested a review from a team as a code owner January 23, 2021 00:56

ewbankkit mentioned this pull request Apr 28, 2021

Add error_output_prefix into aws_kinesis_firehose_delivery_stream extended_s3_configuration/s3_configuration #13416

Closed

ewbankkit mentioned this pull request Apr 28, 2021

Added Error output prefix to Firehose S3 backup configuration #8263

Closed

sleepdeprecation mentioned this pull request Sep 1, 2021

Kinesis Firehose Delivery Streams, S3 Configuration doesn't support error_output_prefix #7997

Closed

breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2021

anGie44 added 2 commits December 13, 2021 17:53

Merge remote-tracking branch 'origin/main' into kinesis_s3_error_outp…

94c92e5

…ut_prefix

terrafmt fix

6f17053

anGie44 self-assigned this Dec 13, 2021

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 23, 2021

CR updates

b2c99bd

anGie44 force-pushed the kinesis_s3_error_output_prefix branch from 91315ab to b2c99bd Compare December 23, 2021 21:31

anGie44 added this to the v3.71.0 milestone Dec 23, 2021

anGie44 approved these changes Dec 23, 2021

View reviewed changes

anGie44 merged commit b9abf1a into hashicorp:main Dec 23, 2021

JeffAshton deleted the kinesis_s3_error_output_prefix branch January 7, 2022 15:00

github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for error_output_prefix to the aws_kinesis_firehose_delivery_stream s3 destination #11229

Adding support for error_output_prefix to the aws_kinesis_firehose_delivery_stream s3 destination #11229

JeffAshton commented Dec 10, 2019 •

edited by anGie44

Loading

JeffAshton Dec 10, 2019

JeffAshton Dec 10, 2019 •

edited

Loading

ewbankkit commented Apr 28, 2021

zhelding commented Oct 19, 2021

JeffAshton commented Oct 19, 2021

zhelding commented Nov 4, 2021

anGie44 commented Dec 23, 2021 •

edited

Loading

anGie44 left a comment

github-actions bot commented Jan 6, 2022

github-actions bot commented May 28, 2022

		@@ -1835,6 +1851,8 @@ func createRedshiftConfig(d schema.ResourceData, s3Config firehose.S3Destinati

		redshift := rl[0].(map[string]interface{})

		s3Config := createS3Config(d, false)

Adding support for error_output_prefix to the aws_kinesis_firehose_delivery_stream s3 destination #11229

Adding support for error_output_prefix to the aws_kinesis_firehose_delivery_stream s3 destination #11229

Conversation

JeffAshton commented Dec 10, 2019 • edited by anGie44 Loading

Community Note

JeffAshton Dec 10, 2019

Choose a reason for hiding this comment

JeffAshton Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Apr 28, 2021

zhelding commented Oct 19, 2021

JeffAshton commented Oct 19, 2021

zhelding commented Nov 4, 2021

anGie44 commented Dec 23, 2021 • edited Loading

anGie44 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2022

github-actions bot commented May 28, 2022

JeffAshton commented Dec 10, 2019 •

edited by anGie44

Loading

JeffAshton Dec 10, 2019 •

edited

Loading

anGie44 commented Dec 23, 2021 •

edited

Loading