Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cloudwatch_log_destination: add plan time validation to role_arn and target_arn #11687

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624
Relates #13826

Release note for CHANGELOG:

resource_aws_cloudwatch_log_destination: add plan time validation to `role_arn` and `target_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudwatchLogDestination_'
--- PASS: TestAccAWSCloudwatchLogDestination_basic (131.03s)
--- PASS: TestAccAWSCloudwatchLogDestination_disappears (129.64s)

@DrFaust92 DrFaust92 requested a review from a team January 21, 2020 13:08
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/cloudwatchlogs tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 21, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 17, 2020
Base automatically changed from master to main January 23, 2021 00:56
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:56
@YakDriver YakDriver self-assigned this Feb 11, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

GovCloud:

--- PASS: TestAccAWSCloudwatchLogDestination_disappears (65.34s)
--- PASS: TestAccAWSCloudwatchLogDestination_basic (72.53s)

us-west-2:

--- PASS: TestAccAWSCloudwatchLogDestination_basic (68.60s)
--- PASS: TestAccAWSCloudwatchLogDestination_disappears (73.40s)

@YakDriver YakDriver added this to the v3.28.0 milestone Feb 11, 2021
@YakDriver YakDriver merged commit 37df9c7 into hashicorp:main Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/cloudwatch-dest branch April 15, 2021 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants