Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_spot_fleet_request: Support tagging #12078

Closed
ewbankkit opened this issue Feb 18, 2020 · 3 comments · Fixed by #12295
Closed

r/aws_spot_fleet_request: Support tagging #12078

ewbankkit opened this issue Feb 18, 2020 · 3 comments · Fixed by #12295
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 18, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

EC2 Spot Fleet request can now be tagged.
These tags apply to the spot fleet request resource and are separate from the tags that can be specified in the launch_specification configuration block and which apply to the EC2 instances in the fleet.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_spot_fleet_request" "example" {
  tags = {
    Usage = "dev"
  }
}

References

Announcement.
API reference.

Requires AWS SDK v1.29.0:

Related:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 18, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 18, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 18, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 8, 2020
@bflad bflad added this to the v2.57.0 milestone Apr 8, 2020
@bflad
Copy link
Contributor

bflad commented Apr 8, 2020

Support for this has been merged and will release with version 2.57.0 of the Terraform AWS Provider, later this week. Thanks to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Apr 10, 2020

This has been released in version 2.57.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants