r/aws_rds_cluster_role_association - New resource #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
mantoine96
force-pushed
the
Add-db_cluster_role_association_resource
branch
2 times, most recently
from
33aa34c
to
ad113f4
Compare
mantoine96
force-pushed
the
Add-db_cluster_role_association_resource
branch
from
ad113f4
to
cafcf3e
Compare
This comment has been minimized.
This comment has been minimized.
|
@breathingdust - do you think you will be able to merge it somewhen soon? we really need this feature |
ewbankkit
removed
the
needs-triage
ewbankkit
force-pushed
the
Add-db_cluster_role_association_resource
branch
from
cafcf3e
to
39306ae
Compare
github-actions
bot
added
service/ec2
ewbankkit
force-pushed
the
Add-db_cluster_role_association_resource
branch
from
a5894a5
to
d90b347
Compare
github-actions
bot
removed
service/ec2
Co-authored-by: Matthieu ANTOINE <[email protected]>
ewbankkit
force-pushed
the
Add-db_cluster_role_association_resource
branch
from
d90b347
to
b56d161
Compare
ewbankkit
changed the title
github-actions
bot
added
the
provider
Note that RDS Cluster IAM Role Associations can now be managed via either the aws_rds_cluster.iam_roles attribute or the aws_rds_cluster_role_association resource, not both.
ewbankkit
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterRoleAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterRoleAssociation_ -timeout 180m
=== RUN TestAccAWSRDSClusterRoleAssociation_basic
=== PAUSE TestAccAWSRDSClusterRoleAssociation_basic
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears_cluster
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears_cluster
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears_role
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears_role
=== CONT TestAccAWSRDSClusterRoleAssociation_basic
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears_role
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears_cluster
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears_cluster (131.22s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears (163.37s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears_role (163.77s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_basic (165.71s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 168.798sGovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterRoleAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterRoleAssociation_ -timeout 180m
=== RUN TestAccAWSRDSClusterRoleAssociation_basic
=== PAUSE TestAccAWSRDSClusterRoleAssociation_basic
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears_cluster
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears_cluster
=== RUN TestAccAWSRDSClusterRoleAssociation_disappears_role
=== PAUSE TestAccAWSRDSClusterRoleAssociation_disappears_role
=== CONT TestAccAWSRDSClusterRoleAssociation_basic
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears_role
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears
=== CONT TestAccAWSRDSClusterRoleAssociation_disappears_cluster
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears (124.68s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears_cluster (135.43s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_disappears_role (146.71s)
--- PASS: TestAccAWSRDSClusterRoleAssociation_basic (147.35s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 150.454s
|
@thehunt33r Thanks for the contribution 🎉 👏. |
|
Thank you @ewbankkit for all the work you've poured in this PR! I had indeed hesitated on the naming of the resource, and I also agree with Looking forward to getting this PR merged and to start using it! |
|
@ewbankkit & @thehunt33r - Thanks for the hard work, this will be very useful for us! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9552
Closes #13641
Release note for CHANGELOG:
Output from acceptance testing:
There seems to a problem with the
iam_rolesargument inaws_rds_cluster, which can also be used to associate a role but only with Aurora MySQL (and doesn't allow passing a feature with the role) and I'd love to have feedback / advice on this.I have two ideas on how to fix this, but both would be breaking changes:
iam_rolesstructure inaws_rds_clusterto belist(object({role_arn=string,feature=string}))which would allow for it to work on both MySQL and PostgreSQL.iam_rolesargument fromaws_rds_clusteraws_db_instanceandaws_db_instance_role_associationAdditionally, I am not sure on the naming. Of course, Aurora clusters use the
aws_rds_*namespace for most of their resources, but there are some usingaws_db_cluster_*. Happy either way.