Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glacier vault import fails #12619

Closed
artamonovkirill opened this issue Apr 1, 2020 · 5 comments · Fixed by #12645
Closed

Glacier vault import fails #12619

artamonovkirill opened this issue Apr 1, 2020 · 5 comments · Fixed by #12645
Assignees
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glacier Issues and PRs that pertain to the glacier service.
Milestone

Comments

@artamonovkirill
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

0.12.24

Affected Resource(s)

  • aws_glacier_vault

Terraform Configuration Files

resource "aws_glacier_vault" "photos" {
  name = "photos"
}

Debug Output

https://gist.githubusercontent.com/artamonovkirill/528f00dd39c908586ed4e68223e2f7cc/raw/477a01e35563e5a27d0cc0c805f0cc430bde73a0/debug.out

Panic Output

https://gist.githubusercontent.com/artamonovkirill/528f00dd39c908586ed4e68223e2f7cc/raw/477a01e35563e5a27d0cc0c805f0cc430bde73a0/crash.log

Expected Behavior

Glacier vault is imported.

Actual Behavior

Terraform crashed.

Steps to Reproduce

terraform import aws_glacier_vault.photos photos

Important Factoids

No.

References

n/a

@ghost ghost added the service/glacier Issues and PRs that pertain to the glacier service. label Apr 1, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 1, 2020
@ewbankkit
Copy link
Contributor

2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: 2020/04/01 22:03:30 [DEBUG] [aws-sdk-go] DEBUG: Response glacier/GetVaultAccessPolicy Details:
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: ---[ RESPONSE ]--------------------------------------
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: HTTP/1.1 403 Forbidden
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: Connection: close
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: Content-Length: 225
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: Content-Type: application/json
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: Date: Wed, 01 Apr 2020 20:03:29 GMT
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: X-Amzn-Requestid: v_XUea471eAsf4s-CKDM8LOOOeXEzzHzVBjYpjwma-oGA-s
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: 
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: 
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: -----------------------------------------------------
2020-04-01T22:03:30.382+0200 [DEBUG] plugin.terraform-provider-aws_v2.55.0_x4: 2020/04/01 22:03:30 [DEBUG] [aws-sdk-go] {"code":"AccessDeniedException","type":"Client","message":"User: arn:aws:iam::123456789012:user/me is not authorized to perform: glacier:GetVaultAccessPolicy on resource: arn:aws:glacier:eu-west-1:123456789012:vaults/photos"}

https://github.com/terraform-providers/terraform-provider-aws/blob/c5e26ae4e683f5eee4724acb25355f665cb5e1ff/aws/resource_aws_glacier_vault.go#L172-L182

pol != nil but *pol.Policy == nil.
The error handling here looks faulty.

@artamonovkirill
Copy link
Author

I still get a panic with 2.60.0, but now a different error: crash.out and debug.out

@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 27, 2020
@bflad bflad added the crash Results from or addresses a Terraform crash or kernel panic. label Jan 29, 2021
@bflad bflad self-assigned this Jan 29, 2021
@github-actions github-actions bot added this to the v3.27.0 milestone Jan 29, 2021
@bflad
Copy link
Contributor

bflad commented Jan 29, 2021

The fix for this has been merged and will release with version 3.27.0 of the Terraform AWS Provider, next week. Thank you to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glacier Issues and PRs that pertain to the glacier service.
Projects
None yet
4 participants