Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure All Singular Data Sources Return Errors on Zero Results #13410

Closed
breathingdust opened this issue May 20, 2020 · 4 comments
Closed

Ensure All Singular Data Sources Return Errors on Zero Results #13410

breathingdust opened this issue May 20, 2020 · 4 comments
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@breathingdust
Copy link
Member

breathingdust commented May 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

For consistency, all Terraform AWS Provider data sources that are expected to return a single result should error if that result is not found. Terraform can have undefined behaviors when this condition occurs and many practitioners now expect these errors.

References

@breathingdust breathingdust added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels May 20, 2020
@breathingdust breathingdust added this to the v3.0.0 milestone May 20, 2020
@bflad
Copy link
Contributor

bflad commented May 20, 2020

Affected Data Sources

  • aws_directory_service_directory (return nil usage)
  • aws_ecr_repository (return nil usage)
  • aws_efs_file_system (return nil usage)
  • aws_launch_template (return nil usage)

@anGie44
Copy link
Contributor

anGie44 commented Jul 21, 2020

closing as affected data sources have been updated and changes will be released with v3.0.0 of the Provider.

@anGie44 anGie44 closed this as completed Jul 21, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

3 participants