Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Sources: aws_apigatewayv2_api(s) #13883

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12954.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_Http
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (27.25s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (27.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.315s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (28.61s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (27.14s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (28.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	83.933s

@ewbankkit ewbankkit requested a review from a team June 22, 2020 22:14
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 22, 2020
@ewbankkit ewbankkit force-pushed the f-aws_apigatewayv2_api-data-source branch from 1750d20 to 4749916 Compare June 23, 2020 22:31
@ewbankkit ewbankkit changed the title [WIP] New Data Sources: aws_apigatewayv2_api(s) New Data Sources: aws_apigatewayv2_api(s) Jun 24, 2020
@DrFaust92
Copy link
Collaborator

@ewbankkit can you rebase?

@michaelmerrill
Copy link

@ewbankkit any update on this?

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@ewbankkit ewbankkit force-pushed the f-aws_apigatewayv2_api-data-source branch from fa3fb84 to 187222b Compare February 17, 2021 16:32
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (13.52s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (13.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.049s
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (15.14s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (13.91s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.974s
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (13.35s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (13.65s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.872s
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (15.20s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (15.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.675s
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (42.07s)
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (33.09s)
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (37.05s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic (194.66s)
    --- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/createCertificate (4.24s)
    --- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/basic (54.27s)
    --- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/disappears (47.45s)
    --- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/ApiMappingKey (88.70s)
--- PASS: TestAccAWSAPIGatewayV2Api_disappears (27.47s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (33.08s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (35.00s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (38.15s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (39.52s)
--- PASS: TestAccAWSAPIGatewayV2Api_QuickCreate (41.62s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (64.60s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi_WithTags (79.89s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi (80.65s)
--- PASS: TestAccAWSAPIGatewayV2Api_OpenapiWithMoreFields (83.20s)
--- PASS: TestAccAWSAPIGatewayV2Api_CorsConfiguration (89.98s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi_WithCorsConfiguration (100.33s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (110.92s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (114.23s)

@DrFaust92 DrFaust92 removed their assignment Feb 18, 2021
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
go: downloading github.com/hashicorp/terraform-exec v0.13.0
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (15.03s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (15.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       22.761s

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (15.25s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (12.66s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (25.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       56.303s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN   TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT  TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (10.14s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (10.62s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       13.733s

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (10.22s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
x--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (10.98s)
=== RUN   TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       36.993s

@breathingdust breathingdust merged commit 91d803f into hashicorp:main Feb 23, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 23, 2021
@ewbankkit ewbankkit deleted the f-aws_apigatewayv2_api-data-source branch February 23, 2021 17:47
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New data source: aws_apigatewayv2_api
4 participants