-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Sources: aws_apigatewayv2_api(s) #13883
New Data Sources: aws_apigatewayv2_api(s) #13883
Conversation
1750d20
to
4749916
Compare
@ewbankkit can you rebase? |
@ewbankkit any update on this? |
fa3fb84
to
187222b
Compare
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m === RUN TestAccAWSAPIGatewayV2ApiDataSource_Http === PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http === RUN TestAccAWSAPIGatewayV2ApiDataSource_WebSocket === PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket === CONT TestAccAWSAPIGatewayV2ApiDataSource_Http === CONT TestAccAWSAPIGatewayV2ApiDataSource_WebSocket --- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (13.52s) --- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (13.95s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 14.049s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m === RUN TestAccAWSAPIGatewayV2ApisDataSource_Name --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (15.14s) === RUN TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (13.91s) === RUN TestAccAWSAPIGatewayV2ApisDataSource_Tags --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.83s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 41.974s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m === RUN TestAccAWSAPIGatewayV2ApisDataSource_Name --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (13.35s) === RUN TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (13.65s) === RUN TestAccAWSAPIGatewayV2ApisDataSource_Tags --- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.78s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 39.872s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m === RUN TestAccAWSAPIGatewayV2ApiDataSource_Http === PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http === RUN TestAccAWSAPIGatewayV2ApiDataSource_WebSocket === PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket === CONT TestAccAWSAPIGatewayV2ApiDataSource_Http === CONT TestAccAWSAPIGatewayV2ApiDataSource_WebSocket --- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (15.20s) --- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (15.56s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 15.675s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (42.07s)
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (33.09s)
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (37.05s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic (194.66s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/createCertificate (4.24s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/basic (54.27s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/disappears (47.45s)
--- PASS: TestAccAWSAPIGatewayV2ApiMapping_basic/ApiMappingKey (88.70s)
--- PASS: TestAccAWSAPIGatewayV2Api_disappears (27.47s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (33.08s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (35.00s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicHttp (38.15s)
--- PASS: TestAccAWSAPIGatewayV2Api_basicWebSocket (39.52s)
--- PASS: TestAccAWSAPIGatewayV2Api_QuickCreate (41.62s)
--- PASS: TestAccAWSAPIGatewayV2Api_Tags (64.60s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi_WithTags (79.89s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi (80.65s)
--- PASS: TestAccAWSAPIGatewayV2Api_OpenapiWithMoreFields (83.20s)
--- PASS: TestAccAWSAPIGatewayV2Api_CorsConfiguration (89.98s)
--- PASS: TestAccAWSAPIGatewayV2Api_Openapi_WithCorsConfiguration (100.33s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesWebSocket (110.92s)
--- PASS: TestAccAWSAPIGatewayV2Api_AllAttributesHttp (114.23s)
LGTM 🚀 Thanks @ewbankkit! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
go: downloading github.com/hashicorp/terraform-exec v0.13.0
=== RUN TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (15.03s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (15.97s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 22.761s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (15.25s)
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (12.66s)
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (25.22s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 56.303s Verified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApiDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApiDataSource_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2ApiDataSource_Http
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_Http
=== RUN TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== PAUSE TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
=== CONT TestAccAWSAPIGatewayV2ApiDataSource_Http
=== CONT TestAccAWSAPIGatewayV2ApiDataSource_WebSocket
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_Http (10.14s)
--- PASS: TestAccAWSAPIGatewayV2ApiDataSource_WebSocket (10.62s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 13.733s
make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2ApisDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2ApisDataSource_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_Name
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Name (10.22s)
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType
x--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_ProtocolType (10.98s)
=== RUN TestAccAWSAPIGatewayV2ApisDataSource_Tags
--- PASS: TestAccAWSAPIGatewayV2ApisDataSource_Tags (12.56s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 36.993s |
This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #12954.
Output from acceptance testing: