Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to targets for aws_route #14995

Closed
gdavison opened this issue Sep 2, 2020 · 3 comments · Fixed by #16930
Closed

Add validation to targets for aws_route #14995

gdavison opened this issue Sep 2, 2020 · 3 comments · Fixed by #16930
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Sep 2, 2020

Description

The aws_route resource allows practitioners to incorrectly add more than one target type, when only one can be used. tflint has added a check to prevent this, but we should implement it in the provider.

Use ExactlyOneOf, since one of the targets is required.

New or Affected Resource(s)

  • aws_route
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 2, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 2, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 4, 2020

We should also be able to do this for destination type destination_cidr_block and destination_ipv6_cidr_block (and destination_prefix_list_id for #13986).

The TestAccAWSRoute_ConditionalCidrBlock acceptance test case fails if ExactlyOneOf is applied to destination_cidr_block and destination_ipv6_cidr_block. This can be enabled once #13943 is addressed.

@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.