Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: new datasource cloudfront_canonical_user_id #15167

Merged
merged 14 commits into from
Sep 23, 2021
Merged

feature: new datasource cloudfront_canonical_user_id #15167

merged 14 commits into from
Sep 23, 2021
+174 −4

Conversation

hgsgtk
Copy link
Contributor

@hgsgtk hgsgtk commented Sep 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12512

Release note for CHANGELOG:

New Resource: aws_awslogsdelivery_canonical_user_id

Output from acceptance testing:

AWS_PROFILE="hgsgtk" make testacc TESTARGS='-run=TestAccCloudfrontCanonicalUserId_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccCloudfrontCanonicalUserId_basic -timeout 120m
=== RUN   TestAccCloudfrontCanonicalUserId_basic
=== PAUSE TestAccCloudfrontCanonicalUserId_basic
=== CONT  TestAccCloudfrontCanonicalUserId_basic
--- PASS: TestAccCloudfrontCanonicalUserId_basic (40.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.658s

AWS_PROFILE="hgsgtk" make testacc TESTARGS='-run=TestAccCloudfrontCanonicalUserIdCheck_chinaRegion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccCloudfrontCanonicalUserIdCheck_chinaRegion -timeout 120m
=== RUN   TestAccCloudfrontCanonicalUserIdCheck_chinaRegion
=== RUN   TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-north-1
=== PAUSE TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-north-1
=== RUN   TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-northwest-1
=== PAUSE TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-northwest-1
=== CONT  TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-north-1
=== CONT  TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-northwest-1
--- PASS: TestAccCloudfrontCanonicalUserIdCheck_chinaRegion (0.00s)
    --- PASS: TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-north-1 (35.05s)
    --- PASS: TestAccCloudfrontCanonicalUserIdCheck_chinaRegion/cn-northwest-1 (35.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.652s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2020
hgsgtk
hgsgtk commented Sep 16, 2020
View reviewed changes
.hashibot.hcl Outdated Show resolved Hide resolved
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Sep 16, 2020
hgsgtk
hgsgtk commented Sep 16, 2020
View reviewed changes
.hashibot.hcl Outdated Show resolved Hide resolved
@ghost ghost added the service/cloudfront Issues and PRs that pertain to the cloudfront service. label Nov 27, 2020
@hgsgtk hgsgtk changed the title feature: datasource aws_awslogsdelivery_canonical_user_id feature: new datasource cloudfront_canonical_user_id Nov 27, 2020
@hgsgtk hgsgtk marked this pull request as ready for review November 27, 2020 08:14
@hgsgtk hgsgtk requested a review from a team as a code owner November 27, 2020 08:14
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 27, 2020
@hgsgtk
Copy link
Contributor Author

hgsgtk commented Dec 3, 2020 •
edited
Loading

I think it’s ready. Would you review it, please?

@hgsgtk
Copy link
Contributor Author

hgsgtk commented Dec 10, 2020

@bflad I saw you reviewed PR at #16667. I don't know if this is the right place to ask, but I would appreciate a review!

Base automatically changed from master to main January 23, 2021 00:59
@hgsgtk hgsgtk mentioned this pull request Feb 3, 2021
Closed
@hgsgtk
Copy link
Contributor Author

hgsgtk commented Feb 21, 2021

After I merge latest master branch, check 'awsproviderlint' was failed.

Error: /home/runner/work/terraform-provider-aws/terraform-provider-aws/aws/data_source_aws_cloudfront_canonical_user_id.go:11:43: AWSAT003: regions should not be hardcoded, use aws_region and aws_availability_zones data sources instead

I will fix it, and send review request again.

@hgsgtk hgsgtk marked this pull request as draft February 21, 2021 13:26
@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@ewbankkit ewbankkit marked this pull request as ready for review September 23, 2021 16:12
ewbankkit
ewbankkit approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_ -timeout 180m
=== RUN   TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_basic
=== PAUSE TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_basic
=== RUN   TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_default
=== PAUSE TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_default
=== RUN   TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_cn
=== PAUSE TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_cn
=== CONT  TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_basic
=== CONT  TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_cn
=== CONT  TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_default
--- PASS: TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_default (8.73s)
--- PASS: TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_cn (8.77s)
--- PASS: TestAccDataSourceAWSCloudFrontLogDeliveryCanonicalUserId_basic (8.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.451s

@ewbankkit
Copy link
Contributor

@hgsgtk Thanks for the contribution 🎉 👏.

I went ahead and renamed the data source to aws_cloudfront_log_delivery_canonical_user_id.

@ewbankkit ewbankkit merged commit fbb1fa3 into hashicorp:main Sep 23, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 23, 2021
@hgsgtk
Copy link
Contributor Author

hgsgtk commented Sep 23, 2021 •
edited
Loading

Oh! I'm super glad you merged!

@hgsgtk hgsgtk deleted the f-canonical_cloudfront_id branch September 23, 2021 21:05
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@patjlm patjlm mentioned this pull request Jun 17, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectcastro hectcastro hectcastro left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.60.0
Development

Successfully merging this pull request may close these issues.

Canonical ID of CloudFront log delivery account
4 participants
@hgsgtk @ewbankkit @hectcastro @breathingdust