Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_s3control_bucket #15510

Merged
merged 3 commits into from
Oct 27, 2020
Merged

New Resource: aws_s3control_bucket #15510

merged 3 commits into from
Oct 27, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 6, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15413

Release note for CHANGELOG:

* **New Resource:** `aws_s3control_bucket`

Output from acceptance testing:

--- PASS: TestAccAWSS3ControlBucket_basic (58.52s)
--- PASS: TestAccAWSS3ControlBucket_disappears (63.94s)
--- SKIP: TestAccAWSS3ControlBucket_Tags (0.00s)

@bflad bflad added new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service. labels Oct 6, 2020
@bflad bflad self-assigned this Oct 6, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 6, 2020
@bflad bflad marked this pull request as ready for review October 9, 2020 13:56
@bflad bflad requested a review from a team October 9, 2020 13:56
@bflad
Copy link
Contributor Author

bflad commented Oct 9, 2020

tfproviderdocs check is failing because it needs the changes in #15468 -- can move the s3control changes here if desired instead.

@bflad bflad removed their assignment Oct 9, 2020
@bflad bflad mentioned this pull request Oct 12, 2020
Merged
@bflad
Copy link
Contributor Author

bflad commented Oct 12, 2020

We no longer have Outpost access to confirm, but the tags issue may be related to aws/aws-sdk-go#3591 and potentially not eventual consistency.

@bflad
New Resource: aws_s3control_bucket
d21ec0b 
Reference: #15413

Output from acceptance testing:

```
--- PASS: TestAccAWSS3ControlBucket_basic (58.52s)
--- PASS: TestAccAWSS3ControlBucket_disappears (63.94s)
--- SKIP: TestAccAWSS3ControlBucket_Tags (0.00s)
```
@bflad
resource/aws_s3control_bucket: Remove workaround fixed in AWS Go SDK
c58091d 
Reference: aws/aws-sdk-go#3583
anGie44
anGie44 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- quick q below and noting that tags support is implemented but possibly still facing the issue referenced above in the AWS SDK 👍

aws/resource_aws_s3control_bucket_test.go Outdated
_, err = conn.GetBucket(input)

if tfawserr.ErrCodeEquals(err, "NoSuchBucket") {
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we continue through the for-loop here in case? though I've seen it written both ways where we return nil right away instead 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe just peeped #15847 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha yeah, should be continue, will suggest fix and merge

@anGie44 anGie44 mentioned this pull request Oct 27, 2020
Merged
@bflad bflad added this to the v3.13.0 milestone Oct 27, 2020
@bflad bflad merged commit af69dda into master Oct 27, 2020
@bflad bflad deleted the f-aws_s3control_bucket branch October 27, 2020 18:47
bflad added a commit that referenced this pull request Oct 27, 2020
@bflad
Update CHANGELOG for #15510
bd9a877
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_s3control_bucket
2 participants
@bflad @anGie44