aws_rds_cluster_parameter_group is not using pagination the compare to aws_db_parameter_group

[jiashucheniress]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Affected Resource(s)

• aws_rds_cluster_parameter_group

Actual Behavior

Terraform unnecessary decide that it needs to redeploy/modify the aws_rds_cluster_parameter_group after performing terraform plan

Code comparision

We noticed that the terraform always think that the aws_rds_cluster_parameter_group needs to be modified when running terraform plan.

Compare the code between

terraform-provider-aws/aws/resource_aws_db_parameter_group.go

Lines 168 to 175 in 366dd84

	err = rdsconn.DescribeDBParametersPages(&describeParametersOpts,
	func(describeParametersResp *rds.DescribeDBParametersOutput, lastPage bool) bool {
	parameters = append(parameters, describeParametersResp.Parameters...)
	return !lastPage
	})
	if err != nil {
	return err
	}

and

terraform-provider-aws/aws/resource_aws_rds_cluster_parameter_group.go

Lines 155 to 164 in d7041a5

	// Only include user customized parameters as there's hundreds of system/default ones
	describeParametersOpts := rds.DescribeDBClusterParametersInput{
	DBClusterParameterGroupName: aws.String(d.Id()),
	Source: aws.String("user"),
	}
	describeParametersResp, err := rdsconn.DescribeDBClusterParameters(&describeParametersOpts)
	if err != nil {
	return err
	}

It seems to be caused by the aws_rds_cluster_parameter_group api call not using pagination

[github-actions]

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.