Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the new connection pool and outlier detection features in app mesh virtual node resource #16097

Closed
rmaskara opened this issue Nov 9, 2020 · 5 comments · Fixed by #16167
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@rmaskara
Copy link

rmaskara commented Nov 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

support the new connection pool and outlier detection features in app mesh virtual node resource

New or Affected Resource(s)

aws_appmesh_virtual_node

Potential Terraform Configuration

References

https://aws.amazon.com/about-aws/whats-new/2020/11/aws-app-mesh-introduces-circuit-breaker-capabilities/
https://docs.aws.amazon.com/cli/latest/reference/appmesh/create-virtual-node.html

  • #0000
@rmaskara rmaskara added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 9, 2020
@ewbankkit ewbankkit added service/appmesh Issues and PRs that pertain to the appmesh service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2020
@ewbankkit ewbankkit self-assigned this Nov 9, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 11, 2020

aws_appmesh_virtual_gateway
resource "aws_appmesh_virtual_gateway" "example" {
  name      = "example-virtual-gateway"
  mesh_name = "example-service-mesh"

  spec {
    listener {
      port_mapping {
        port     = 8080
        protocol = "http"
      }

      connection_pool {
        http {
          max_connections      = 3
          max_pending_requests = 2
        }
      }
    }
  }
}
aws_appmesh_virtual_node
resource "aws_appmesh_virtual_node" "serviceb1" {
  name      = "example-virtual-node"
  mesh_name = "example-service-mesh"

  spec {
    listener {
      port_mapping {
        port     = 8080
        protocol = "http"
      }

      outlier_detection {
        base_ejection_duration {
          value = 800
          unit  = "ms"
        }

        interval {
          value = 5
          unit  = "s"
        }

        max_ejection_percent = 20
        max_server_errors    = 1
      }
    }
  }
}

@rmaskara
Copy link
Author

rmaskara commented Nov 11, 2020

Hi @ewbankkit, the example config looks good. I was also expecting to see connection pool settings in the virtual node since App Mesh seems to allow overriding these settings at node level as well..

@ewbankkit
Copy link
Contributor

@rmaskara Yes, connection_pool will be a aws_appmesh_virtual_node attribute.

@rkmaskara
Copy link

When are we expecting this be available through a provider version release?

@ghost
Copy link

ghost commented Jan 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
3 participants