Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis application not keeping the order of record_columns #16248

Closed
ghost opened this issue Nov 17, 2020 · 3 comments · Fixed by #16260
Closed

Kinesis application not keeping the order of record_columns #16248

ghost opened this issue Nov 17, 2020 · 3 comments · Fixed by #16260
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service.
Milestone

Comments

@ghost
Copy link

ghost commented Nov 17, 2020

This issue was originally opened by @tfeuser123 as hashicorp/terraform#26943. It was migrated here as a result of the provider split. The original body of the issue is below.


Since Nov. 6 Friday, TFE is mixing column orders defined below. If you see code snippets below, HEADER_TYPE is the 1st column and AWS component (Kinesis Analytics) was keeping the same order as the terraform codes. But since Nov 6 (no changes), DATA_CD is the 1st column and all other columns are mixed up. So, we have to manual re-arrange the column orders from AWS console. More strangely, It works fine on local deploy with S3 backend (I mean it keeps the order). It is happening only for TFE deploy (TFE backend).

schema {
  record_columns {
    name     = "HEADER_TYPE"
    sql_type = "INTEGER"
  }

  record_columns {
    name     = "COL_2"
    sql_type = "INTEGER"
  }
  record_columns {
    name     = "DATA_CD"
    sql_type = "INTEGER"
  }
@ghost ghost added the bug Addresses a defect in current functionality. label Nov 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 17, 2020
@ewbankkit ewbankkit added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 17, 2020
@ewbankkit
Copy link
Contributor

@tfeuser123 Thanks for raising this issue.
#16005 changed the type of record_columns from TypeList to TypeSet hence the loss of column ordering.
I will correct this.

@ghost
Copy link
Author

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link
Author

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service.
Projects
None yet
2 participants