Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ecr_replication_configuration - new resource #16853

Merged
merged 15 commits into from
Apr 5, 2021
Merged

r/ecr_replication_configuration - new resource #16853

merged 15 commits into from
Apr 5, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16668

Release note for CHANGELOG:

resource_aws_ecr_replication_configuration - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrReplicationConfiguration_basic'
--- PASS: TestAccAWSEcrReplicationConfiguration_basic (67.08s)
...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 20, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Dec 20, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Dec 26, 2020
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from dc75b51 to 829facb Compare December 26, 2020 20:10
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from 829facb to dbf7ed7 Compare January 9, 2021 10:21
@DrFaust92 DrFaust92 marked this pull request as ready for review January 9, 2021 10:44
@DrFaust92 DrFaust92 requested a review from a team as a code owner January 9, 2021 10:44
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from ccba97a to c0aebfe Compare January 16, 2021 21:04
Base automatically changed from master to main January 23, 2021 01:00
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from c0aebfe to 6275a86 Compare March 11, 2021 20:50
@marcuz marcuz mentioned this pull request Mar 22, 2021
Closed
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from 6275a86 to b99f1c3 Compare March 27, 2021 16:27
@gdavison gdavison self-assigned this Mar 31, 2021
gdavison
gdavison requested changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions

.changelog/11857.txt Outdated Show resolved Hide resolved
aws/resource_aws_ecr_replication_configuration.go Outdated Show resolved Hide resolved
aws/resource_aws_ecr_replication_configuration_test.go Outdated
resource.TestCheckResourceAttr(resourceName, "replication_configuration.#", "1"),
resource.TestCheckResourceAttr(resourceName, "replication_configuration.0.rule.#", "1"),
resource.TestCheckResourceAttr(resourceName, "replication_configuration.0.rule.0.destination.#", "1"),
resource.TestCheckResourceAttrSet(resourceName, "replication_configuration.0.rule.0.destination.0.region"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worthwhile to use an explicit region, such as testAccGetAlternateRegion() so that we can test for a specific result, here and in the third step

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chnaged, i hope that this is what you meant :D

website/docs/r/ecr_replication_configuration.html.markdown Outdated Show resolved Hide resolved
aws/resource_aws_ecr_replication_configuration_test.go Show resolved Hide resolved
aws/resource_aws_ecr_replication_configuration.go Outdated Show resolved Hide resolved
@DrFaust92 DrFaust92 force-pushed the r/ecr_replication_configuration branch from 7c489a2 to 1c741e5 Compare April 3, 2021 08:51
@DrFaust92 DrFaust92 requested a review from gdavison April 3, 2021 09:07
gdavison
gdavison approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Acceptance test results

--- PASS: TestAccAWSEcrReplicationConfiguration_basic (21.89s)

@gdavison gdavison merged commit c25b788 into hashicorp:main Apr 5, 2021
@github-actions github-actions bot added this to the v3.36.0 milestone Apr 5, 2021
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/ecr_replication_configuration branch April 15, 2021 10:37
@ghost
Copy link

ghost commented May 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecr Issues and PRs that pertain to the ecr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.36.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @gdavison