#13605 added base64decode string before sending to aws-sdk-go, so cer…

[sonikro]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request.

Closes #13605
Relates #15945
Relates #13826

When uploading Oracle Wallet files to aws_dms_certificate, we cant use the file function when reading the certificate file, because the certificate file contains invalid UTF-8 Characters. So we have to use filebase64 function to load the certificate.

Example:

resource "aws_dms_certificate" "oracle-wallet" {
  certificate_id     = "cute-certificate"
  certificate_wallet = filebase64("cwallet_${var.environment}.sso")
}

However, the aws-sdk-go, already encodes the bytearray to base64, when uploading the content to AWS. So if we don't decode the base64 string, before sending to the aws-sdk-go, the aws-sdk-go will encode the content's again, causing the certificate file to be corrupted.

[anGie44]

Hi @sonikro , thank you for creating this PR! the resource change looks like what we need 👍 To get this into the upcoming release, I'm going to push up additional logic to handle encoding the value back on read, else a non-empty plan will result after applying a config with the certificate_wallet argument. In addition, i've taken the opportunity to refactor some bits since there still exists quite some legacy logic.

[anGie44]

Thanks again @sonikro 🚀
Output of acceptance tests (commercial):

--- PASS: TestAccAWSDmsCertificate_disappears (10.21s)
--- PASS: TestAccAWSDmsCertificate_CertificateWallet (13.87s)
--- PASS: TestAccAWSDmsCertificate_basic (13.89s)
--- PASS: TestAccAWSDmsCertificate_tags (31.37s)

[sonikro]

Awesome @anGie44 ! Thanks for improving the code. This is my first time using Go Lang haha. Excited for the next release, so I can finally remove my "work around" code.

[ghost]

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!