Add CodeStar Connection data source #18129

shuheiktgw · 2021-03-16T22:57:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (37.21s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (37.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.177s

Added CodeStar Connection data source. Thank you for your review!

bflad

Some minor testing updates, otherwise this is looking really good, thank you @shuheiktgw 🎉

bflad · 2021-03-19T00:12:09Z

aws/data_source_aws_codestarconnections_connection_test.go

+		PreCheck:  func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },
+		Providers: testAccProviders,


We are currently in the process of adding ErrorCheck to each of the acceptance tests. Reference: #18175

Can you please add this here? Thank you!

Suggested change

PreCheck: func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },

Providers: testAccProviders,

PreCheck: func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },

ErrorCheck: testAccErrorCheck(t, codestarconnections.EndpointsID),

Providers: testAccProviders,

bflad · 2021-03-19T00:15:18Z

aws/data_source_aws_codestarconnections_connection_test.go

+					testAccMatchResourceAttrRegionalARN(resourceName, "id", "codestar-connections", regexp.MustCompile("connection/.+")),
+					testAccMatchResourceAttrRegionalARN(resourceName, "arn", "codestar-connections", regexp.MustCompile("connection/.+")),
+					resource.TestCheckResourceAttr(resourceName, "provider_type", codestarconnections.ProviderTypeBitbucket),
+					resource.TestCheckResourceAttr(resourceName, "name", rName),
+					resource.TestCheckResourceAttr(resourceName, "connection_status", codestarconnections.ConnectionStatusPending),


For data source testing, we prefer using resource.TestCheckResourceAttrPair() where possible to simplify it. 👍 Reference: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/running-and-writing-acceptance-tests.md#data-source-acceptance-testing

Suggested change

testAccMatchResourceAttrRegionalARN(resourceName, "id", "codestar-connections", regexp.MustCompile("connection/.+")),

testAccMatchResourceAttrRegionalARN(resourceName, "arn", "codestar-connections", regexp.MustCompile("connection/.+")),

resource.TestCheckResourceAttr(resourceName, "provider_type", codestarconnections.ProviderTypeBitbucket),

resource.TestCheckResourceAttr(resourceName, "name", rName),

resource.TestCheckResourceAttr(resourceName, "connection_status", codestarconnections.ConnectionStatusPending),

resource.TestCheckResourceAttrPair(dataSourceName, "arn", resourceName, "arn"),

resource.TestCheckResourceAttrPair(dataSourceName, "connection_status", resourceName, "connection_status"),

resource.TestCheckResourceAttrPair(dataSourceName, "id", resourceName, "id"),

resource.TestCheckResourceAttrPair(dataSourceName, "provider_type", resourceName, "provider_type"),

resource.TestCheckResourceAttrPair(dataSourceName, "name", resourceName, "name"),

resource.TestCheckResourceAttrPair(dataSourceName, "tags.%", resourceName, "tags.%"),

bflad · 2021-03-19T00:15:50Z

aws/data_source_aws_codestarconnections_connection_test.go

+
+func TestAccDataSourceAwsCodeStarConnectionsConnection_basic(t *testing.T) {
+	rName := acctest.RandomWithPrefix("tf-acc-test")
+	resourceName := "data.aws_codestarconnections_connection.test"


So it can be referenced below 😄

Suggested change

resourceName := "data.aws_codestarconnections_connection.test"

dataSourceName := "data.aws_codestarconnections_connection.test"

resourceName := "aws_codestarconnections_connection.test"

bflad · 2021-03-19T00:16:33Z

aws/data_source_aws_codestarconnections_connection_test.go

+
+func TestAccDataSourceAwsCodeStarConnectionsConnection_tags(t *testing.T) {
+	rName := acctest.RandomWithPrefix("tf-acc-test")
+	resourceName := "data.aws_codestarconnections_connection.test"


Similarly:

Suggested change

resourceName := "data.aws_codestarconnections_connection.test"

dataSourceName := "data.aws_codestarconnections_connection.test"

resourceName := "aws_codestarconnections_connection.test"

bflad · 2021-03-19T00:16:58Z

aws/data_source_aws_codestarconnections_connection_test.go

+		PreCheck:  func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },
+		Providers: testAccProviders,


Similarly:

Suggested change

PreCheck: func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },

Providers: testAccProviders,

PreCheck: func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },

ErrorCheck: testAccErrorCheck(t, codestarconnections.EndpointsID),

Providers: testAccProviders,

bflad · 2021-03-19T00:17:26Z

aws/data_source_aws_codestarconnections_connection_test.go

+					resource.TestCheckResourceAttr(resourceName, "tags.%", "2"),
+					resource.TestCheckResourceAttr(resourceName, "tags.key1", "value1"),
+					resource.TestCheckResourceAttr(resourceName, "tags.key2", "value2"),


Suggested change

resource.TestCheckResourceAttr(resourceName, "tags.%", "2"),

resource.TestCheckResourceAttr(resourceName, "tags.key1", "value1"),

resource.TestCheckResourceAttr(resourceName, "tags.key2", "value2"),

resource.TestCheckResourceAttrPair(dataSourceName, "tags.%", resourceName, "tags.%"),

shuheiktgw · 2021-03-19T02:41:04Z

Thanks, @bflad! Updated the tests, so would you review the PR again?

$ make testacc TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection_ -timeout 180m
go: downloading github.com/hashicorp/go-multierror v1.1.1
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (45.73s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (68.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.859s

bflad

Looks good to me 🚀 (Forgot to mention adding a changelog entry before 😅 will do so on merge)

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (19.66s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (19.69s)

--- PASS: TestAccAWSCodeStarConnectionsConnection_disappears (12.08s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Basic (16.27s)
--- PASS: TestAccAWSCodeStarConnectionsConnection_Tags (35.69s)

shuheiktgw · 2021-03-21T05:18:28Z

Thank you for your review, @bflad!

ghost · 2021-03-26T00:57:30Z

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-04-18T17:10:32Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. labels Mar 16, 2021

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2021

shuheiktgw force-pushed the add_codestarconnections_connection_data_source branch from 7e4ae2f to dbcccdf Compare March 16, 2021 23:49

shuheiktgw marked this pull request as ready for review March 17, 2021 23:50

shuheiktgw requested a review from a team as a code owner March 17, 2021 23:50

bflad added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 19, 2021

bflad self-assigned this Mar 19, 2021

bflad suggested changes Mar 19, 2021

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 19, 2021

shuheiktgw added 4 commits March 19, 2021 11:16

Add CodeStar Connection data source

ad0c7a8

Add tests for CodeStar Connection data source

9244a7f

Add a documentation for CodeStar Connection data source

615b031

Update CodeStar Connection data source tests

48142f8

shuheiktgw force-pushed the add_codestarconnections_connection_data_source branch from adcc7ed to 48142f8 Compare March 19, 2021 02:39

ghost removed waiting-response Maintainers are waiting on response from community or contributor. labels Mar 19, 2021

shuheiktgw requested a review from bflad March 19, 2021 04:56

bflad approved these changes Mar 19, 2021

View reviewed changes

bflad merged commit a652d4a into hashicorp:main Mar 19, 2021

github-actions bot added this to the v3.34.0 milestone Mar 19, 2021

bflad added a commit that referenced this pull request Mar 19, 2021

Update CHANGELOG for #18129

1621015

shuheiktgw deleted the add_codestarconnections_connection_data_source branch March 21, 2021 05:18

ghost locked as resolved and limited conversation to collaborators Apr 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CodeStar Connection data source #18129

Add CodeStar Connection data source #18129

shuheiktgw commented Mar 16, 2021 •

edited

Loading

bflad left a comment

bflad Mar 19, 2021

bflad Mar 19, 2021

bflad Mar 19, 2021

bflad Mar 19, 2021

bflad Mar 19, 2021

bflad Mar 19, 2021

shuheiktgw commented Mar 19, 2021

bflad left a comment

shuheiktgw commented Mar 21, 2021

ghost commented Mar 26, 2021

ghost commented Apr 18, 2021

		PreCheck: func() { testAccPreCheck(t); testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t) },
		Providers: testAccProviders,

-					testAccMatchResourceAttrRegionalARN(resourceName, "id", "codestar-connections", regexp.MustCompile("connection/.+")),
-					testAccMatchResourceAttrRegionalARN(resourceName, "arn", "codestar-connections", regexp.MustCompile("connection/.+")),
-					resource.TestCheckResourceAttr(resourceName, "provider_type", codestarconnections.ProviderTypeBitbucket),
-					resource.TestCheckResourceAttr(resourceName, "name", rName),
-					resource.TestCheckResourceAttr(resourceName, "connection_status", codestarconnections.ConnectionStatusPending),
+					resource.TestCheckResourceAttrPair(dataSourceName, "arn", resourceName, "arn"),
+					resource.TestCheckResourceAttrPair(dataSourceName, "connection_status", resourceName, "connection_status"),
+					resource.TestCheckResourceAttrPair(dataSourceName, "id", resourceName, "id"),
+					resource.TestCheckResourceAttrPair(dataSourceName, "provider_type", resourceName, "provider_type"),
+					resource.TestCheckResourceAttrPair(dataSourceName, "name", resourceName, "name"),
+					resource.TestCheckResourceAttrPair(dataSourceName, "tags.%", resourceName, "tags.%"),

	resourceName := "data.aws_codestarconnections_connection.test"
	dataSourceName := "data.aws_codestarconnections_connection.test"
	resourceName := "aws_codestarconnections_connection.test"

Add CodeStar Connection data source #18129

Add CodeStar Connection data source #18129

Conversation

shuheiktgw commented Mar 16, 2021 • edited Loading

Community Note

bflad left a comment

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

bflad Mar 19, 2021

Choose a reason for hiding this comment

shuheiktgw commented Mar 19, 2021

bflad left a comment

Choose a reason for hiding this comment

shuheiktgw commented Mar 21, 2021

ghost commented Mar 26, 2021

ghost commented Apr 18, 2021

shuheiktgw commented Mar 16, 2021 •

edited

Loading