Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudhsm_v2_hsm: Prevent orphaned HSM Instances by additionally matching on ENI identifier during lookup #18580

Merged
merged 2 commits into from
Apr 6, 2021
Merged

resource/aws_cloudhsm_v2_hsm: Prevent orphaned HSM Instances by additionally matching on ENI identifier during lookup #18580

merged 2 commits into from
Apr 6, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 6, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8648
Reference: #16796

Also implements the paginated function to prevent missed matches in large environments and tidies up the existing test.

Output from acceptance testing:

--- PASS: TestAccAWSCloudHsmV2Hsm_basic (856.31s)

@bflad
resource/aws_cloudhsm_v2_hsm: Prevent orphaned HSM Instances by addit…
e6568e8 
…ionally matching on ENI identifier during lookup

Reference: #8648
Reference: #16796

Also implements the paginated function to prevent missed matches in large environments and tidies up the existing test.

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudHsmV2Hsm_basic (856.31s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Apr 6, 2021
@bflad bflad requested a review from a team as a code owner April 6, 2021 05:37
@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 6, 2021
@bflad bflad added the service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. label Apr 6, 2021
@bflad bflad mentioned this pull request Apr 6, 2021
Closed
anGie44
anGie44 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! LGTM 👍 👍 (aside: i think the extra Import func could be removed right? since we don't need to set that extra field. totally out of scope of this tho :) )

@bflad
Copy link
Contributor Author

bflad commented Apr 6, 2021

@anGie44 totally! Let's do a second pass with this resource -- it needs some disappears and tags testing as well as fixing the mismatched file names.

@bflad bflad merged commit c6a83f8 into main Apr 6, 2021
@bflad bflad deleted the b-aws_cloudhsmv2_hsm-eni-matching branch April 6, 2021 16:00
@github-actions github-actions bot added this to the v3.36.0 milestone Apr 6, 2021
github-actions bot pushed a commit that referenced this pull request Apr 6, 2021
Update CHANGELOG.md for #18580
5a568a1
@anGie44 anGie44 mentioned this pull request Apr 6, 2021
Closed
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.36.0
2 participants
@bflad @anGie44