Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds/efs_mount_target: Add access_point_id, file_system_id args #18918

Merged
merged 6 commits into from
Apr 23, 2021
Merged

ds/efs_mount_target: Add access_point_id, file_system_id args #18918

merged 6 commits into from
Apr 23, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 16, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18859

Output from acceptance testing (Commercial):

--- PASS: TestAccDataSourceAwsEfsMountTarget_byAccessPointID (135.41s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byFileSystemID (137.30s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_basic (137.43s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccDataSourceAwsEfsMountTarget_basic (129.79s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byAccessPointID (137.91s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byFileSystemID (140.12s)

@YakDriver YakDriver requested a review from a team as a code owner April 16, 2021 16:48
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 16, 2021
@YakDriver YakDriver mentioned this pull request Apr 16, 2021
Closed
@anGie44 anGie44 self-assigned this Apr 22, 2021
anGie44
anGie44 reviewed Apr 22, 2021
View reviewed changes
website/docs/d/efs_mount_target.html.markdown
@@ -27,14 +27,15 @@ data "aws_efs_mount_target" "by_id" {

The following arguments are supported:

* `mount_target_id` - (Required) ID of the mount target that you want to have described
* `access_point_id` - (Optional) ID or ARN of the access point whose mount target that you want to find. It must be included if a `file_system_id` and `mount_target_id` are not included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `access_point_id` - (Optional) ID or ARN of the access point whose mount target that you want to find. It must be included if a `file_system_id` and `mount_target_id` are not included.
* `access_point_id` - (Optional) ID or ARN of the access point whose mount target you want to find. It must be included if a `file_system_id` and `mount_target_id` are not included.

anGie44
anGie44 reviewed Apr 22, 2021
View reviewed changes
website/docs/d/efs_mount_target.html.markdown
@@ -27,14 +27,15 @@ data "aws_efs_mount_target" "by_id" {

The following arguments are supported:

* `mount_target_id` - (Required) ID of the mount target that you want to have described
* `access_point_id` - (Optional) ID or ARN of the access point whose mount target that you want to find. It must be included if a `file_system_id` and `mount_target_id` are not included.
* `file_system_id` - (Optional) ID or ARN of the file system whose mount target that you want to find. It must be included if an `access_point_id` and `mount_target_id` are not included.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `file_system_id` - (Optional) ID or ARN of the file system whose mount target that you want to find. It must be included if an `access_point_id` and `mount_target_id` are not included.
* `file_system_id` - (Optional) ID or ARN of the file system whose mount target you want to find. It must be included if an `access_point_id` and `mount_target_id` are not included.

anGie44
anGie44 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Super tiny nits in the docs (dropping the that in the 2 sentences i think reads better but lmk otherwise! )

Output of acceptance tests:

--- PASS: TestAccDataSourceAwsEfsMountTarget_byAccessPointID (136.40s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_basic (138.68s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_byFileSystemID (138.68s)

@YakDriver YakDriver added this to the v3.38.0 milestone Apr 23, 2021
@YakDriver YakDriver merged commit e73ef9a into main Apr 23, 2021
@YakDriver YakDriver deleted the f-ds-efs-mount-target-access branch April 23, 2021 20:19
github-actions bot pushed a commit that referenced this pull request Apr 23, 2021
Update CHANGELOG.md for #18918
7ff960c
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.

aws_efs_mount_target data source lookup by file_system_id and access_point_id
2 participants
@YakDriver @anGie44