Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_batch_compute_environment: Enforce no compute_resources block for UNMANAGED compute environments #19087

Closed
ewbankkit opened this issue Apr 23, 2021 · 2 comments · Fixed by #22805
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/batch Issues and PRs that pertain to the batch service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Relates: #16819.
Currently the aws_batch_compute_environment resource allows a compute_resources block to be specified when type = "UMANAGED" even though the AWS API does not allow this.
There is code in the resource implementation to ignore this attribute during Create and Read for UNMANAGED compute environments.

The correct validation should be done during terraform plan (via CustomizeDiff).
This is a breaking change as currently "valid" configurations will now become invalid.

New or Affected Resource(s)

  • aws_batch_compute_environment
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 23, 2021
@ghost ghost added the service/batch Issues and PRs that pertain to the batch service. label Apr 23, 2021
@ewbankkit ewbankkit added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Apr 23, 2021
@anGie44 anGie44 added this to the v4.0.0 milestone Jan 11, 2022
@ewbankkit ewbankkit self-assigned this Jan 27, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
2 participants