-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/apprunner_service: fix resource creation with instance role and instance_configuration #19483
Conversation
d3e6b77
to
463d39b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppRunnerService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppRunnerService_ -timeout 180m
=== RUN TestAccAwsAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_basic
=== RUN TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== RUN TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== RUN TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
=== RUN TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== PAUSE TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== RUN TestAccAwsAppRunnerService_disappears
=== PAUSE TestAccAwsAppRunnerService_disappears
=== RUN TestAccAwsAppRunnerService_tags
=== PAUSE TestAccAwsAppRunnerService_tags
=== CONT TestAccAwsAppRunnerService_ImageRepository_basic
=== CONT TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration
=== CONT TestAccAwsAppRunnerService_tags
=== CONT TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration
=== CONT TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration
=== CONT TestAccAwsAppRunnerService_disappears
=== CONT TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration
--- PASS: TestAccAwsAppRunnerService_ImageRepository_basic (229.38s)
--- PASS: TestAccAwsAppRunnerService_tags (248.20s)
--- PASS: TestAccAwsAppRunnerService_disappears (257.13s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_InstanceConfiguration (375.09s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_AutoScalingConfiguration (382.60s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_EncryptionConfiguration (449.17s)
--- PASS: TestAccAwsAppRunnerService_ImageRepository_HealthCheckConfiguration (507.23s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 510.794s
This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19484
Notes:
instance_configuration
cpu
andmemory
values returned from API and set in state did not match original values if configured invCPU
orGB
, respectively. ThusDiffSuppressFuncs
have been added to address these.Output from acceptance testing: