-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudwatch_event_target - fix input transformer input paths validation #19703
r/aws_cloudwatch_event_target - fix input transformer input paths validation #19703
Conversation
…idation Set max items to be 100 to match current [AWS Documentation][1] [1]: https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_InputTransformer.html#API_InputTransformer_Contents
be173ee
to
55502d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @kromol ! only note for next time is to make sure to add a .changelog/<PR-Number>.txt
file to describe the changes and check if the documentation needs to be updated (I missed this on first review 😅). Thank you for this fix! 🚀 🚀
Output of acceptance tests (in commercial):
--- SKIP: TestAccAWSCloudWatchEventTarget_PartnerEventBus (0.00s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (37.84s)
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (40.63s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (41.10s)
--- PASS: TestAccAWSCloudWatchEventTarget_http (41.89s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (43.65s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (51.78s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (53.03s)
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (58.20s)
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (58.33s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (64.26s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (69.18s)
--- PASS: TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig (74.79s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (76.74s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (77.31s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (95.13s)
This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Set max items to be 100 to match current AWS Documentation
Community Note
Closes #19698
Output from acceptance testing: