-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time_zone parameter to aws_autoscaling_schedule #19829
Add time_zone parameter to aws_autoscaling_schedule #19829
Conversation
I've marked this as a draft, because I'm not sure if this needs more updates to the resource test. I've updated one of the test cases to use the new parameter, maybe it's enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @maerlyn 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution!
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAutoscalingSchedule_ -timeout 180m
=== RUN TestAccAWSAutoscalingSchedule_basic
=== PAUSE TestAccAWSAutoscalingSchedule_basic
=== RUN TestAccAWSAutoscalingSchedule_disappears
=== PAUSE TestAccAWSAutoscalingSchedule_disappears
=== RUN TestAccAWSAutoscalingSchedule_recurrence
=== PAUSE TestAccAWSAutoscalingSchedule_recurrence
=== RUN TestAccAWSAutoscalingSchedule_zeroValues
=== PAUSE TestAccAWSAutoscalingSchedule_zeroValues
=== RUN TestAccAWSAutoscalingSchedule_negativeOne
=== PAUSE TestAccAWSAutoscalingSchedule_negativeOne
=== CONT TestAccAWSAutoscalingSchedule_basic
=== CONT TestAccAWSAutoscalingSchedule_zeroValues
=== CONT TestAccAWSAutoscalingSchedule_negativeOne
=== CONT TestAccAWSAutoscalingSchedule_disappears
=== CONT TestAccAWSAutoscalingSchedule_recurrence
--- PASS: TestAccAWSAutoscalingSchedule_disappears (139.70s)
--- PASS: TestAccAWSAutoscalingSchedule_negativeOne (139.88s)
--- PASS: TestAccAWSAutoscalingSchedule_recurrence (140.75s)
--- PASS: TestAccAWSAutoscalingSchedule_zeroValues (142.25s)
--- PASS: TestAccAWSAutoscalingSchedule_basic (143.16s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 143.223s
This functionality has been released in v3.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: