Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/vpn_connection: replace DescribeTransitGatewayAttachments with paginated method #20775

Merged

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Sep 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Notes

  • (From Customer): At a large number of AWS Transit Gateway Attachments (999+), the AWS API call DescribeTransitGatewayAttachments will return an initial empty response with pagination token even when querying for a unique TGW Attachment. This results in the error "error finding EC2 VPN Connection (%s) Transit Gateway Attachment: empty response".

Output from acceptance testing:

--- PASS: TestAccAWSVpnConnection_tunnelOptions (338.05s)
--- PASS: TestAccAWSVpnConnection_Tunnel1PresharedKey (229.08s)
--- PASS: TestAccAWSVpnConnection_Tunnel1InsideCidr (310.85s)
--- PASS: TestAccAWSVpnConnection_specifyIpv4 (311.84s)
--- PASS: TestAccAWSVpnConnection_tunnelOptionsLesser (313.71s)
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (390.94s)
--- PASS: TestAccAWSVpnConnection_disappears (531.94s)
--- PASS: TestAccAWSVpnConnection_tags (570.34s)
--- PASS: TestAccAWSVpnConnection_withIpv6 (648.72s)
--- PASS: TestAccAWSVpnConnection_withEnableAcceleration (652.61s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (652.65s)
--- PASS: TestAccAWSVpnConnection_Tunnel1InsideIpv6Cidr (712.52s)
--- PASS: TestAccAWSVpnConnection_basic (795.24s)
--- PASS: TestAccAWSVpnConnection_specifyIpv6 (476.51s)

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. and removed service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 2, 2021
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 2, 2021
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 2, 2021
@anGie44 anGie44 marked this pull request as ready for review September 2, 2021 19:58
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v3.57.0 milestone Sep 2, 2021
@anGie44 anGie44 merged commit 93cb5d5 into main Sep 2, 2021
@anGie44 anGie44 deleted the f-use-paginated-associations-method-for-vpn-association branch September 2, 2021 20:58
github-actions bot pushed a commit that referenced this pull request Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants