Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_iam_users #20877

Merged
merged 5 commits into from
Sep 21, 2021

Conversation

kamilturek
Copy link
Collaborator

This PR adds new data source - aws_iam_users.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20682.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSIAMUsersDataSource"                                                                                  х INT
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMUsersDataSource -timeout 180m
=== RUN   TestAccAWSIAMUsersDataSource_nameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nameRegex
=== RUN   TestAccAWSIAMUsersDataSource_pathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_pathPrefix
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nameRegex
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_pathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentNameRegex
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentPathPrefix (22.97s)
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentNameRegex (22.97s)
--- PASS: TestAccAWSIAMUsersDataSource_pathPrefix (25.19s)
--- PASS: TestAccAWSIAMUsersDataSource_nameRegex (25.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       32.861s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 11, 2021
@kamilturek kamilturek marked this pull request as ready for review September 11, 2021 15:10
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSIAMUsersDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMUsersDataSource_ -timeout 180m
=== RUN   TestAccAWSIAMUsersDataSource_nameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nameRegex
=== RUN   TestAccAWSIAMUsersDataSource_pathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_pathPrefix
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== RUN   TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== PAUSE TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nameRegex
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentPathPrefix
=== CONT  TestAccAWSIAMUsersDataSource_nonExistentNameRegex
=== CONT  TestAccAWSIAMUsersDataSource_pathPrefix
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentNameRegex (9.40s)
--- PASS: TestAccAWSIAMUsersDataSource_nonExistentPathPrefix (9.46s)
--- PASS: TestAccAWSIAMUsersDataSource_pathPrefix (11.75s)
--- PASS: TestAccAWSIAMUsersDataSource_nameRegex (12.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.228s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b27b6c1 into hashicorp:main Sep 21, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 21, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Source: aws_iam_users
3 participants