Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_docdb_global_cluster: Support for DocDB Global Clusters #20978

Merged
merged 38 commits into from
Nov 11, 2021

Conversation

larssnellman
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Adds a new resource aws_docdb_global_cluster.
Resource aws_docdb_cluster now supports argument global_cluster_identifier.

This implementation follows nearly the same implementation of aws_rds_global_cluster since the DocDB and RDS API are similar.

Closes #19933

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDocDBCluster'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDocDBCluster -timeout 180m
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== RUN   TestAccAWSDocDBClusterInstance_az
=== PAUSE TestAccAWSDocDBClusterInstance_az
=== RUN   TestAccAWSDocDBClusterInstance_namePrefix
=== PAUSE TestAccAWSDocDBClusterInstance_namePrefix
=== RUN   TestAccAWSDocDBClusterInstance_generatedName
=== PAUSE TestAccAWSDocDBClusterInstance_generatedName
=== RUN   TestAccAWSDocDBClusterInstance_kmsKey
=== PAUSE TestAccAWSDocDBClusterInstance_kmsKey
=== RUN   TestAccAWSDocDBClusterInstance_disappears
=== PAUSE TestAccAWSDocDBClusterInstance_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDocDBClusterParameterGroup_basic
=== RUN   TestAccAWSDocDBClusterParameterGroup_systemParameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_systemParameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDocDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDocDBClusterParameterGroup_Description
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Description
=== RUN   TestAccAWSDocDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDocDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_Parameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Parameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_Tags
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Tags
=== RUN   TestAccAWSDocDBClusterSnapshot_basic
=== PAUSE TestAccAWSDocDBClusterSnapshot_basic
=== RUN   TestAccAWSDocDBCluster_basic
=== PAUSE TestAccAWSDocDBCluster_basic
=== RUN   TestAccAWSDocDBCluster_namePrefix
=== PAUSE TestAccAWSDocDBCluster_namePrefix
=== RUN   TestAccAWSDocDBCluster_generatedName
=== PAUSE TestAccAWSDocDBCluster_generatedName
=== RUN   TestAccAWSDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccAWSDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccAWSDocDBCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccAWSDocDBCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccAWSDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccAWSDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccAWSDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccAWSDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccAWSDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccAWSDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccAWSDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccAWSDocDBCluster_takeFinalSnapshot
=== RUN   TestAccAWSDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccAWSDocDBCluster_missingUserNameCausesError
=== RUN   TestAccAWSDocDBCluster_updateTags
=== PAUSE TestAccAWSDocDBCluster_updateTags
=== RUN   TestAccAWSDocDBCluster_updateCloudwatchLogsExports
=== PAUSE TestAccAWSDocDBCluster_updateCloudwatchLogsExports
=== RUN   TestAccAWSDocDBCluster_kmsKey
=== PAUSE TestAccAWSDocDBCluster_kmsKey
=== RUN   TestAccAWSDocDBCluster_encrypted
=== PAUSE TestAccAWSDocDBCluster_encrypted
=== RUN   TestAccAWSDocDBCluster_backupsUpdate
=== PAUSE TestAccAWSDocDBCluster_backupsUpdate
=== RUN   TestAccAWSDocDBCluster_Port
=== PAUSE TestAccAWSDocDBCluster_Port
=== RUN   TestAccAWSDocDBCluster_deleteProtection
=== PAUSE TestAccAWSDocDBCluster_deleteProtection
=== CONT  TestAccAWSDocDBClusterInstance_basic
=== CONT  TestAccAWSDocDBCluster_namePrefix
=== CONT  TestAccAWSDocDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDocDBCluster_deleteProtection
=== CONT  TestAccAWSDocDBCluster_Port
=== CONT  TestAccAWSDocDBCluster_backupsUpdate
=== CONT  TestAccAWSDocDBCluster_encrypted
=== CONT  TestAccAWSDocDBCluster_kmsKey
=== CONT  TestAccAWSDocDBCluster_updateCloudwatchLogsExports
=== CONT  TestAccAWSDocDBCluster_updateTags
=== CONT  TestAccAWSDocDBCluster_missingUserNameCausesError
=== CONT  TestAccAWSDocDBCluster_takeFinalSnapshot
=== CONT  TestAccAWSDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== CONT  TestAccAWSDocDBCluster_GlobalClusterIdentifier_Update
=== CONT  TestAccAWSDocDBCluster_GlobalClusterIdentifier_Remove
=== CONT  TestAccAWSDocDBCluster_GlobalClusterIdentifier_Add
=== CONT  TestAccAWSDocDBCluster_GlobalClusterIdentifier
=== CONT  TestAccAWSDocDBClusterInstance_kmsKey
=== CONT  TestAccAWSDocDBCluster_generatedName
=== CONT  TestAccAWSDocDBClusterInstance_namePrefix
--- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (39.29s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_systemParameter
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (52.95s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_basic
--- PASS: TestAccAWSDocDBClusterParameterGroup_systemParameter (22.31s)
=== CONT  TestAccAWSDocDBClusterInstance_disappears
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (21.35s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_Parameter
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (36.30s)
=== CONT  TestAccAWSDocDBCluster_basic
--- PASS: TestAccAWSDocDBCluster_generatedName (145.05s)
=== CONT  TestAccAWSDocDBClusterSnapshot_basic
--- PASS: TestAccAWSDocDBCluster_namePrefix (175.19s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_Tags
--- PASS: TestAccAWSDocDBCluster_GlobalClusterIdentifier_Add (196.09s)
=== CONT  TestAccAWSDocDBClusterInstance_generatedName
--- PASS: TestAccAWSDocDBCluster_encrypted (200.55s)
=== CONT  TestAccAWSDocDBClusterInstance_az
--- PASS: TestAccAWSDocDBCluster_GlobalClusterIdentifier_Update (211.74s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_generatedName
--- PASS: TestAccAWSDocDBCluster_GlobalClusterIdentifier_Remove (220.65s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_Description
--- PASS: TestAccAWSDocDBCluster_kmsKey (221.79s)
=== CONT  TestAccAWSDocDBClusterParameterGroup_disappears
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (48.77s)
--- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (230.74s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (21.06s)
--- PASS: TestAccAWSDocDBCluster_GlobalClusterIdentifier (234.99s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (15.48s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (21.60s)
--- PASS: TestAccAWSDocDBCluster_updateTags (242.55s)
--- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (247.21s)
--- PASS: TestAccAWSDocDBCluster_backupsUpdate (251.15s)
--- PASS: TestAccAWSDocDBCluster_basic (158.96s)
--- PASS: TestAccAWSDocDBCluster_deleteProtection (310.45s)
--- PASS: TestAccAWSDocDBCluster_Port (381.90s)
--- PASS: TestAccAWSDocDBClusterSnapshot_basic (287.57s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (692.11s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (755.02s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (760.82s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (842.45s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (654.80s)
--- PASS: TestAccAWSDocDBClusterInstance_az (666.60s)
--- PASS: TestAccAWSDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1723.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1726.313s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 21, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @larssnellman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@larssnellman larssnellman marked this pull request as ready for review September 21, 2021 22:21
@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2021
@meet-bhagdev
Copy link

@larssnellman larssnellman - thank you for the PR!

Terraform team - any updates on when can this be merged?

@sgotur
Copy link

sgotur commented Sep 30, 2021

@larssnellman thank you for the PR! My customer is also waiting for terraform module for Global cluster feature.

@AdamTylerLynch
Copy link
Collaborator

Notice: I'm going to pick up this PR and start working on it.

@github-actions github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Oct 16, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ozbillwang
Copy link

@larssnellman @AdamTylerLynch

could you help to resolve the conflicts and let the PR review move on?

thanks

…lude information on the argument database_name
@github-actions github-actions bot added the pre-service-packages Includes pre-Service Packages aspects. label Oct 26, 2021
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Oct 26, 2021
@AdamTylerLynch
Copy link
Collaborator

make testacc TESTARGS='-run=TestAccDocDBGlobal' PKG_NAME=internal/service/docdb ACCTEST PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run=TestAccDocDBGlobal -timeout 180m
=== RUN TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN TestAccDocDBGlobalCluster_disappears
=== PAUSE TestAccDocDBGlobalCluster_disappears
=== RUN TestAccDocDBGlobalCluster_DatabaseName
=== PAUSE TestAccDocDBGlobalCluster_DatabaseName
=== RUN TestAccDocDBGlobalCluster_DeletionProtection
=== PAUSE TestAccDocDBGlobalCluster_DeletionProtection
=== RUN TestAccDocDBGlobalCluster_Engine
=== PAUSE TestAccDocDBGlobalCluster_Engine
=== RUN TestAccDocDBGlobalCluster_EngineVersion
=== PAUSE TestAccDocDBGlobalCluster_EngineVersion
=== RUN TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== RUN TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== RUN TestAccDocDBGlobalCluster_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT TestAccDocDBGlobalCluster_basic
=== CONT TestAccDocDBGlobalCluster_EngineVersion
=== CONT TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== CONT TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT TestAccDocDBGlobalCluster_DeletionProtection
=== CONT TestAccDocDBGlobalCluster_Engine
=== CONT TestAccDocDBGlobalCluster_DatabaseName
=== CONT TestAccDocDBGlobalCluster_disappears
=== CONT TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
--- PASS: TestAccDocDBGlobalCluster_disappears (38.22s)
--- PASS: TestAccDocDBGlobalCluster_basic (45.79s)
--- PASS: TestAccDocDBGlobalCluster_EngineVersion (46.11s)
--- PASS: TestAccDocDBGlobalCluster_Engine (46.53s)
--- PASS: TestAccDocDBGlobalCluster_DatabaseName (64.07s)
--- PASS: TestAccDocDBGlobalCluster_StorageEncrypted (64.44s)
--- PASS: TestAccDocDBGlobalCluster_DeletionProtection (92.23s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier (153.28s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (153.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/docdb 155.930s

@larssnellman larssnellman changed the title [WIP] r/aws_docdb_global_cluster: Support for DocDB Global Clusters r/aws_docdb_global_cluster: Support for DocDB Global Clusters Nov 10, 2021
@AdamTylerLynch
Copy link
Collaborator

Ready for Hashi review.

@AdamTylerLynch
Copy link
Collaborator

make testacc TESTARGS='-run=TestAccDocDB' PKG_NAME=internal/service/docdb ACCTEST              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run=TestAccDocDB -timeout 180m
=== RUN   TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN   TestAccDocDBClusterInstance_az
=== PAUSE TestAccDocDBClusterInstance_az
=== RUN   TestAccDocDBClusterInstance_namePrefix
=== PAUSE TestAccDocDBClusterInstance_namePrefix
=== RUN   TestAccDocDBClusterInstance_generatedName
=== PAUSE TestAccDocDBClusterInstance_generatedName
=== RUN   TestAccDocDBClusterInstance_kmsKey
=== PAUSE TestAccDocDBClusterInstance_kmsKey
=== RUN   TestAccDocDBClusterInstance_disappears
=== PAUSE TestAccDocDBClusterInstance_disappears
=== RUN   TestAccDocDBClusterParameterGroup_basic
=== PAUSE TestAccDocDBClusterParameterGroup_basic
=== RUN   TestAccDocDBClusterParameterGroup_systemParameter
=== PAUSE TestAccDocDBClusterParameterGroup_systemParameter
=== RUN   TestAccDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccDocDBClusterParameterGroup_generatedName
=== RUN   TestAccDocDBClusterParameterGroup_description
=== PAUSE TestAccDocDBClusterParameterGroup_description
=== RUN   TestAccDocDBClusterParameterGroup_disappears
=== PAUSE TestAccDocDBClusterParameterGroup_disappears
=== RUN   TestAccDocDBClusterParameterGroup_parameter
=== PAUSE TestAccDocDBClusterParameterGroup_parameter
=== RUN   TestAccDocDBClusterParameterGroup_tags
=== PAUSE TestAccDocDBClusterParameterGroup_tags
=== RUN   TestAccDocDBClusterSnapshot_basic
=== PAUSE TestAccDocDBClusterSnapshot_basic
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBCluster_namePrefix
=== PAUSE TestAccDocDBCluster_namePrefix
=== RUN   TestAccDocDBCluster_generatedName
=== PAUSE TestAccDocDBCluster_generatedName
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccDocDBCluster_takeFinalSnapshot
=== RUN   TestAccDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccDocDBCluster_missingUserNameCausesError
=== RUN   TestAccDocDBCluster_updateTags
=== PAUSE TestAccDocDBCluster_updateTags
=== RUN   TestAccDocDBCluster_updateCloudWatchLogsExports
=== PAUSE TestAccDocDBCluster_updateCloudWatchLogsExports
=== RUN   TestAccDocDBCluster_kmsKey
=== PAUSE TestAccDocDBCluster_kmsKey
=== RUN   TestAccDocDBCluster_encrypted
=== PAUSE TestAccDocDBCluster_encrypted
=== RUN   TestAccDocDBCluster_backupsUpdate
=== PAUSE TestAccDocDBCluster_backupsUpdate
=== RUN   TestAccDocDBCluster_port
=== PAUSE TestAccDocDBCluster_port
=== RUN   TestAccDocDBCluster_deleteProtection
=== PAUSE TestAccDocDBCluster_deleteProtection
=== RUN   TestAccDocDBEngineVersionDataSource_basic
=== PAUSE TestAccDocDBEngineVersionDataSource_basic
=== RUN   TestAccDocDBEngineVersionDataSource_preferred
=== PAUSE TestAccDocDBEngineVersionDataSource_preferred
=== RUN   TestAccDocDBEngineVersionDataSource_defaultOnly
=== PAUSE TestAccDocDBEngineVersionDataSource_defaultOnly
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_disappears
=== PAUSE TestAccDocDBGlobalCluster_disappears
=== RUN   TestAccDocDBGlobalCluster_DatabaseName
=== PAUSE TestAccDocDBGlobalCluster_DatabaseName
=== RUN   TestAccDocDBGlobalCluster_DeletionProtection
=== PAUSE TestAccDocDBGlobalCluster_DeletionProtection
=== RUN   TestAccDocDBGlobalCluster_Engine
=== PAUSE TestAccDocDBGlobalCluster_Engine
=== RUN   TestAccDocDBGlobalCluster_EngineVersion
=== PAUSE TestAccDocDBGlobalCluster_EngineVersion
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== RUN   TestAccDocDBGlobalCluster_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_StorageEncrypted
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_basic
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_basic
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_preferred
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_preferred
=== RUN   TestAccDocDBSubnetGroup_basic
=== PAUSE TestAccDocDBSubnetGroup_basic
=== RUN   TestAccDocDBSubnetGroup_disappears
=== PAUSE TestAccDocDBSubnetGroup_disappears
=== RUN   TestAccDocDBSubnetGroup_namePrefix
=== PAUSE TestAccDocDBSubnetGroup_namePrefix
=== RUN   TestAccDocDBSubnetGroup_generatedName
=== PAUSE TestAccDocDBSubnetGroup_generatedName
=== RUN   TestAccDocDBSubnetGroup_updateDescription
=== PAUSE TestAccDocDBSubnetGroup_updateDescription
=== CONT  TestAccDocDBClusterInstance_basic
=== CONT  TestAccDocDBCluster_updateCloudWatchLogsExports
=== CONT  TestAccDocDBCluster_updateTags
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== CONT  TestAccDocDBSubnetGroup_updateDescription
=== CONT  TestAccDocDBSubnetGroup_generatedName
=== CONT  TestAccDocDBSubnetGroup_namePrefix
=== CONT  TestAccDocDBSubnetGroup_disappears
=== CONT  TestAccDocDBSubnetGroup_basic
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_preferred
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_basic
=== CONT  TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== CONT  TestAccDocDBClusterParameterGroup_tags
=== CONT  TestAccDocDBCluster_missingUserNameCausesError
=== CONT  TestAccDocDBCluster_takeFinalSnapshot
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== CONT  TestAccDocDBGlobalCluster_EngineVersion
=== CONT  TestAccDocDBGlobalCluster_Engine
--- PASS: TestAccDocDBCluster_missingUserNameCausesError (23.88s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_basic (36.71s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_preferred (38.56s)
=== CONT  TestAccDocDBClusterParameterGroup_systemParameter
--- PASS: TestAccDocDBGlobalCluster_EngineVersion (51.50s)
=== CONT  TestAccDocDBClusterParameterGroup_parameter
=== CONT  TestAccDocDBClusterParameterGroup_disappears
--- PASS: TestAccDocDBGlobalCluster_Engine (51.86s)
--- PASS: TestAccDocDBSubnetGroup_disappears (61.42s)
=== CONT  TestAccDocDBClusterParameterGroup_description
--- PASS: TestAccDocDBSubnetGroup_generatedName (63.81s)
=== CONT  TestAccDocDBClusterParameterGroup_generatedName
=== CONT  TestAccDocDBClusterParameterGroup_namePrefix
--- PASS: TestAccDocDBSubnetGroup_basic (63.91s)
--- PASS: TestAccDocDBSubnetGroup_namePrefix (68.82s)
=== CONT  TestAccDocDBEngineVersionDataSource_preferred
--- PASS: TestAccDocDBClusterParameterGroup_systemParameter (38.63s)
=== CONT  TestAccDocDBGlobalCluster_DeletionProtection
=== CONT  TestAccDocDBEngineVersionDataSource_basic
--- PASS: TestAccDocDBGlobalCluster_StorageEncrypted (78.01s)
--- PASS: TestAccDocDBClusterParameterGroup_disappears (27.45s)
=== CONT  TestAccDocDBCluster_backupsUpdate
--- PASS: TestAccDocDBEngineVersionDataSource_preferred (30.05s)
=== CONT  TestAccDocDBCluster_encrypted
--- PASS: TestAccDocDBEngineVersionDataSource_basic (34.77s)
=== CONT  TestAccDocDBCluster_deleteProtection
--- PASS: TestAccDocDBClusterParameterGroup_tags (114.15s)
=== CONT  TestAccDocDBCluster_kmsKey
=== CONT  TestAccDocDBCluster_port
--- PASS: TestAccDocDBClusterParameterGroup_namePrefix (52.67s)
--- PASS: TestAccDocDBClusterParameterGroup_generatedName (52.93s)
=== CONT  TestAccDocDBGlobalCluster_DatabaseName
--- PASS: TestAccDocDBClusterParameterGroup_description (55.32s)
=== CONT  TestAccDocDBGlobalCluster_basic
--- PASS: TestAccDocDBSubnetGroup_updateDescription (119.23s)
=== CONT  TestAccDocDBGlobalCluster_disappears
--- PASS: TestAccDocDBClusterParameterGroup_parameter (87.02s)
=== CONT  TestAccDocDBClusterInstance_kmsKey
--- PASS: TestAccDocDBGlobalCluster_disappears (37.45s)
=== CONT  TestAccDocDBCluster_namePrefix
--- PASS: TestAccDocDBGlobalCluster_basic (47.71s)
=== CONT  TestAccDocDBEngineVersionDataSource_defaultOnly
--- PASS: TestAccDocDBEngineVersionDataSource_defaultOnly (14.57s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier
--- PASS: TestAccDocDBGlobalCluster_DatabaseName (64.27s)
=== CONT  TestAccDocDBCluster_generatedName
--- PASS: TestAccDocDBGlobalCluster_DeletionProtection (107.70s)
=== CONT  TestAccDocDBClusterInstance_disappears
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Add (214.69s)
=== CONT  TestAccDocDBCluster_basic
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Remove (199.66s)
=== CONT  TestAccDocDBClusterSnapshot_basic
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Update (213.32s)
=== CONT  TestAccDocDBClusterParameterGroup_basic
--- PASS: TestAccDocDBCluster_takeFinalSnapshot (237.54s)
=== CONT  TestAccDocDBClusterInstance_generatedName
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier (238.07s)
=== CONT  TestAccDocDBClusterInstance_az
--- PASS: TestAccDocDBCluster_updateTags (250.35s)
=== CONT  TestAccDocDBClusterInstance_namePrefix
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (251.65s)
--- PASS: TestAccDocDBCluster_encrypted (162.25s)
--- PASS: TestAccDocDBClusterParameterGroup_basic (24.08s)
--- PASS: TestAccDocDBCluster_updateCloudWatchLogsExports (278.92s)
--- PASS: TestAccDocDBCluster_backupsUpdate (217.70s)
--- PASS: TestAccDocDBCluster_kmsKey (184.90s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier (155.90s)
--- PASS: TestAccDocDBCluster_namePrefix (179.77s)
--- PASS: TestAccDocDBCluster_generatedName (158.93s)
--- PASS: TestAccDocDBCluster_basic (137.64s)
--- PASS: TestAccDocDBCluster_deleteProtection (331.02s)
--- PASS: TestAccDocDBClusterSnapshot_basic (213.85s)
--- PASS: TestAccDocDBCluster_port (350.69s)
--- PASS: TestAccDocDBClusterInstance_basic (702.76s)
--- PASS: TestAccDocDBClusterInstance_kmsKey (587.44s)
--- PASS: TestAccDocDBClusterInstance_namePrefix (514.44s)
--- PASS: TestAccDocDBClusterInstance_disappears (596.31s)
--- PASS: TestAccDocDBClusterInstance_generatedName (630.48s)
--- PASS: TestAccDocDBClusterInstance_az (657.32s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1604.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	1606.806s

@ewbankkit ewbankkit self-assigned this Nov 11, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS="-run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_" PKG_NAME="internal/service/docdb"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_ -timeout 180m
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBCluster_namePrefix
=== PAUSE TestAccDocDBCluster_namePrefix
=== RUN   TestAccDocDBCluster_generatedName
=== PAUSE TestAccDocDBCluster_generatedName
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Add
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccDocDBCluster_takeFinalSnapshot
=== RUN   TestAccDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccDocDBCluster_missingUserNameCausesError
=== RUN   TestAccDocDBCluster_updateTags
=== PAUSE TestAccDocDBCluster_updateTags
=== RUN   TestAccDocDBCluster_updateCloudWatchLogsExports
=== PAUSE TestAccDocDBCluster_updateCloudWatchLogsExports
=== RUN   TestAccDocDBCluster_kmsKey
=== PAUSE TestAccDocDBCluster_kmsKey
=== RUN   TestAccDocDBCluster_encrypted
=== PAUSE TestAccDocDBCluster_encrypted
=== RUN   TestAccDocDBCluster_backupsUpdate
=== PAUSE TestAccDocDBCluster_backupsUpdate
=== RUN   TestAccDocDBCluster_port
=== PAUSE TestAccDocDBCluster_port
=== RUN   TestAccDocDBCluster_deleteProtection
=== PAUSE TestAccDocDBCluster_deleteProtection
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_disappears
=== PAUSE TestAccDocDBGlobalCluster_disappears
=== RUN   TestAccDocDBGlobalCluster_DatabaseName
=== PAUSE TestAccDocDBGlobalCluster_DatabaseName
=== RUN   TestAccDocDBGlobalCluster_DeletionProtection
=== PAUSE TestAccDocDBGlobalCluster_DeletionProtection
=== RUN   TestAccDocDBGlobalCluster_Engine
=== PAUSE TestAccDocDBGlobalCluster_Engine
=== RUN   TestAccDocDBGlobalCluster_EngineVersion
=== PAUSE TestAccDocDBGlobalCluster_EngineVersion
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== RUN   TestAccDocDBGlobalCluster_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBCluster_basic
=== CONT  TestAccDocDBCluster_backupsUpdate
=== CONT  TestAccDocDBGlobalCluster_EngineVersion
=== CONT  TestAccDocDBCluster_takeFinalSnapshot
=== CONT  TestAccDocDBGlobalCluster_Engine
=== CONT  TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== CONT  TestAccDocDBGlobalCluster_DeletionProtection
=== CONT  TestAccDocDBGlobalCluster_DatabaseName
=== CONT  TestAccDocDBGlobalCluster_disappears
=== CONT  TestAccDocDBGlobalCluster_basic
=== CONT  TestAccDocDBCluster_deleteProtection
=== CONT  TestAccDocDBCluster_port
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== CONT  TestAccDocDBCluster_encrypted
=== CONT  TestAccDocDBCluster_kmsKey
=== CONT  TestAccDocDBCluster_updateCloudWatchLogsExports
=== CONT  TestAccDocDBCluster_updateTags
=== CONT  TestAccDocDBCluster_missingUserNameCausesError
--- PASS: TestAccDocDBCluster_missingUserNameCausesError (22.65s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Add
--- PASS: TestAccDocDBGlobalCluster_disappears (34.50s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
--- PASS: TestAccDocDBGlobalCluster_EngineVersion (39.40s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
--- PASS: TestAccDocDBGlobalCluster_Engine (41.78s)
=== CONT  TestAccDocDBCluster_generatedName
--- PASS: TestAccDocDBGlobalCluster_basic (41.95s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier
--- PASS: TestAccDocDBGlobalCluster_DatabaseName (58.54s)
=== CONT  TestAccDocDBCluster_namePrefix
--- PASS: TestAccDocDBGlobalCluster_StorageEncrypted (58.75s)
--- PASS: TestAccDocDBGlobalCluster_DeletionProtection (85.31s)
--- PASS: TestAccDocDBCluster_encrypted (170.02s)
--- PASS: TestAccDocDBCluster_basic (172.56s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier (147.90s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Remove (152.57s)
--- PASS: TestAccDocDBCluster_namePrefix (133.82s)
--- PASS: TestAccDocDBCluster_generatedName (152.81s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Add (173.75s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier (208.32s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (208.58s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_Update (175.79s)
--- PASS: TestAccDocDBCluster_updateCloudWatchLogsExports (230.36s)
--- PASS: TestAccDocDBCluster_backupsUpdate (232.32s)
--- PASS: TestAccDocDBCluster_kmsKey (235.05s)
--- PASS: TestAccDocDBCluster_takeFinalSnapshot (235.38s)
--- PASS: TestAccDocDBCluster_updateTags (235.90s)
--- PASS: TestAccDocDBCluster_deleteProtection (304.56s)
--- PASS: TestAccDocDBCluster_port (368.20s)
--- PASS: TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (1776.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	1781.903s
GovCloud
% make testacc TESTARGS="-run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_" PKG_NAME="internal/service/docdb"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/docdb/... -v -count 1 -parallel 20 -run=TestAccDocDBGlobalCluster_\|TestAccDocDBCluster_ -timeout 180m
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBCluster_namePrefix
=== PAUSE TestAccDocDBCluster_namePrefix
=== RUN   TestAccDocDBCluster_generatedName
=== PAUSE TestAccDocDBCluster_generatedName
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Add
    cluster_test.go:187: DocDB Global Cluster is not supported in GovCloud partition
--- SKIP: TestAccDocDBCluster_GlobalClusterIdentifier_Add (0.00s)
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== RUN   TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== PAUSE TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== RUN   TestAccDocDBCluster_takeFinalSnapshot
=== PAUSE TestAccDocDBCluster_takeFinalSnapshot
=== RUN   TestAccDocDBCluster_missingUserNameCausesError
=== PAUSE TestAccDocDBCluster_missingUserNameCausesError
=== RUN   TestAccDocDBCluster_updateTags
=== PAUSE TestAccDocDBCluster_updateTags
=== RUN   TestAccDocDBCluster_updateCloudWatchLogsExports
=== PAUSE TestAccDocDBCluster_updateCloudWatchLogsExports
=== RUN   TestAccDocDBCluster_kmsKey
=== PAUSE TestAccDocDBCluster_kmsKey
=== RUN   TestAccDocDBCluster_encrypted
=== PAUSE TestAccDocDBCluster_encrypted
=== RUN   TestAccDocDBCluster_backupsUpdate
=== PAUSE TestAccDocDBCluster_backupsUpdate
=== RUN   TestAccDocDBCluster_port
=== PAUSE TestAccDocDBCluster_port
=== RUN   TestAccDocDBCluster_deleteProtection
=== PAUSE TestAccDocDBCluster_deleteProtection
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_disappears
=== PAUSE TestAccDocDBGlobalCluster_disappears
=== RUN   TestAccDocDBGlobalCluster_DatabaseName
=== PAUSE TestAccDocDBGlobalCluster_DatabaseName
=== RUN   TestAccDocDBGlobalCluster_DeletionProtection
=== PAUSE TestAccDocDBGlobalCluster_DeletionProtection
=== RUN   TestAccDocDBGlobalCluster_Engine
=== PAUSE TestAccDocDBGlobalCluster_Engine
=== RUN   TestAccDocDBGlobalCluster_EngineVersion
=== PAUSE TestAccDocDBGlobalCluster_EngineVersion
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== RUN   TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== RUN   TestAccDocDBGlobalCluster_StorageEncrypted
=== PAUSE TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBCluster_basic
=== CONT  TestAccDocDBCluster_backupsUpdate
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
=== CONT  TestAccDocDBGlobalCluster_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier
=== CONT  TestAccDocDBCluster_encrypted
=== CONT  TestAccDocDBCluster_kmsKey
=== CONT  TestAccDocDBCluster_updateCloudWatchLogsExports
=== CONT  TestAccDocDBCluster_updateTags
=== CONT  TestAccDocDBCluster_missingUserNameCausesError
=== CONT  TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted
=== CONT  TestAccDocDBGlobalCluster_Engine
=== CONT  TestAccDocDBGlobalCluster_EngineVersion
=== CONT  TestAccDocDBCluster_generatedName
=== CONT  TestAccDocDBCluster_deleteProtection
=== CONT  TestAccDocDBCluster_takeFinalSnapshot
=== CONT  TestAccDocDBGlobalCluster_disappears
=== CONT  TestAccDocDBGlobalCluster_basic
=== CONT  TestAccDocDBCluster_namePrefix
=== CONT  TestAccDocDBGlobalCluster_EngineVersion
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 9f731292-6ea8-4286-a1fd-b60a444f1395
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_EngineVersion (17.22s)
=== CONT  TestAccDocDBCluster_port
=== CONT  TestAccDocDBGlobalCluster_disappears
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 8b41331c-c9fd-479b-b6fa-17052feefc43
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_disappears (17.99s)
=== CONT  TestAccDocDBGlobalCluster_DeletionProtection
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Remove
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 01b43e82-efed-46b7-81ee-6900398df216
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
=== CONT  TestAccDocDBGlobalCluster_basic
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 7cd65f32-39f0-4bbb-b6c1-b52114d722f1
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBCluster_GlobalClusterIdentifier_Remove (19.24s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
=== CONT  TestAccDocDBGlobalCluster_Engine
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 3252b45a-6eaf-43e4-b119-52b624846a75
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_basic (19.43s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
=== CONT  TestAccDocDBGlobalCluster_StorageEncrypted
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 872a0435-33e4-4bd4-9bfa-1aaa13b381fa
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_Engine (19.61s)
=== CONT  TestAccDocDBGlobalCluster_DatabaseName
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: a96696cc-afca-4999-b920-0fbfa8095c3e
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_StorageEncrypted (19.85s)
--- SKIP: TestAccDocDBCluster_GlobalClusterIdentifier (20.10s)
--- PASS: TestAccDocDBCluster_missingUserNameCausesError (20.15s)
=== CONT  TestAccDocDBGlobalCluster_DeletionProtection
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 9fde4bce-9774-4b0c-a651-67de0c3dd282
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_DeletionProtection (7.91s)
=== CONT  TestAccDocDBGlobalCluster_DatabaseName
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 7e8badef-4b0d-4740-b152-4cfddf511b45
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_Update
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: 12dc0ab6-b8cb-4230-90f2-a42280db6f04
        
          with aws_docdb_global_cluster.test[1],
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: d4ab7ac7-cf7b-4e19-a2e5-b50ea6e9ae5e
        
          with aws_docdb_global_cluster.test[0],
          on terraform_plugin_test.tf line 2, in resource "aws_docdb_global_cluster" "test":
           2: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBGlobalCluster_DatabaseName (7.56s)
--- SKIP: TestAccDocDBCluster_GlobalClusterIdentifier_Update (7.78s)
=== CONT  TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters
    acctest.go:945: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating DocDB Global Cluster: InvalidParameterValue: Global clusters are not supported for engine: docdb
        	status code: 400, request id: fbd6672b-fa50-449a-9fc8-e33fe0f46dd5
        
          with aws_docdb_global_cluster.test,
          on terraform_plugin_test.tf line 16, in resource "aws_docdb_global_cluster" "test":
          16: resource "aws_docdb_global_cluster" "test" {
        
--- SKIP: TestAccDocDBCluster_GlobalClusterIdentifier_PrimarySecondaryClusters (13.39s)
--- PASS: TestAccDocDBCluster_generatedName (137.30s)
--- PASS: TestAccDocDBCluster_basic (138.93s)
--- PASS: TestAccDocDBCluster_kmsKey (161.81s)
--- PASS: TestAccDocDBCluster_encrypted (174.35s)
--- PASS: TestAccDocDBCluster_namePrefix (181.96s)
--- PASS: TestAccDocDBCluster_updateCloudWatchLogsExports (216.84s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier_StorageEncrypted (218.28s)
--- PASS: TestAccDocDBGlobalCluster_SourceDbClusterIdentifier (218.33s)
--- PASS: TestAccDocDBCluster_takeFinalSnapshot (222.68s)
--- PASS: TestAccDocDBCluster_backupsUpdate (242.48s)
--- PASS: TestAccDocDBCluster_updateTags (242.71s)
--- PASS: TestAccDocDBCluster_deleteProtection (274.54s)
--- PASS: TestAccDocDBCluster_port (280.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	301.868s

@ewbankkit
Copy link
Contributor

@larssnellman @AdamTylerLynch Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fb6b6e6 into hashicorp:main Nov 11, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 11, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocDB Global Cluster Support
8 participants