r/db_event_subscription - fix adding new `event_categories` to existing resource #21338

kamilturek · 2021-10-17T20:41:53Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21319. The regression was introduced by 23b49f6.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccRDSEventSubscription" PKG_NAME="internal/service/rds"                                                        х INT 1m 29s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds -v -count 1 -parallel 20 -run=TestAccRDSEventSubscription -timeout 180m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_disappears
=== CONT  TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_categories
=== CONT  TestAccRDSEventSubscription_Name_generated
=== CONT  TestAccRDSEventSubscription_namePrefix
=== CONT  TestAccRDSEventSubscription_tags
--- PASS: TestAccRDSEventSubscription_disappears (92.03s)
--- PASS: TestAccRDSEventSubscription_basic (100.60s)
--- PASS: TestAccRDSEventSubscription_Name_generated (108.90s)
--- PASS: TestAccRDSEventSubscription_namePrefix (109.00s)
--- PASS: TestAccRDSEventSubscription_tags (150.36s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (157.10s)
--- PASS: TestAccRDSEventSubscription_categories (212.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	218.511s

https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region

added the following settings: IncludeTransactionDetails IncludePartitionValue PartitionIncludeSchemaTable IncludeTableAlterOperations IncludeControlDetails IncludeNullAndEmpty

added the new elements to the schema of the Kinesis settings

removed a "}," that should not have been removed :-)

Acceptance test output: $ make testacc TESTARGS='-run=TestAccDMSEndpoint_kinesis' PKG_NAME=internal/service/dms ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/dms -v -count 1 -parallel 20 -run=TestAccDMSEndpoint_kinesis -timeout 180m === RUN TestAccDMSEndpoint_kinesis === PAUSE TestAccDMSEndpoint_kinesis === CONT TestAccDMSEndpoint_kinesis --- PASS: TestAccDMSEndpoint_kinesis (182.20s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 182.255s

Co-authored-by: Dirk Avery <[email protected]>

Bumps [integrations/github](https://github.com/integrations/terraform-provider-github) from 4.16.0 to 4.17.0. - [Release notes](https://github.com/integrations/terraform-provider-github/releases) - [Changelog](https://github.com/integrations/terraform-provider-github/blob/main/CHANGELOG.md) - [Commits](integrations/terraform-provider-github@v4.16.0...v4.17.0) --- updated-dependencies: - dependency-name: integrations/github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.41.2 to 1.41.4. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.41.2...v1.41.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS="-run=TestAccRDSEventSubscription_" PKG_NAME="internal/service/rds"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds -v -count 1 -parallel 20 -run=TestAccRDSEventSubscription_ -timeout 180m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_tags
=== CONT  TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_disappears
=== CONT  TestAccRDSEventSubscription_categories
=== CONT  TestAccRDSEventSubscription_Name_generated
=== CONT  TestAccRDSEventSubscription_namePrefix
--- PASS: TestAccRDSEventSubscription_disappears (80.61s)
--- PASS: TestAccRDSEventSubscription_basic (85.29s)
--- PASS: TestAccRDSEventSubscription_namePrefix (85.35s)
--- PASS: TestAccRDSEventSubscription_Name_generated (85.42s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (100.25s)
--- PASS: TestAccRDSEventSubscription_tags (111.55s)
--- PASS: TestAccRDSEventSubscription_categories (169.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	172.520s

GovCloud

% make testacc TESTARGS="-run=TestAccRDSEventSubscription_" PKG_NAME="internal/service/rds"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds -v -count 1 -parallel 20 -run=TestAccRDSEventSubscription_ -timeout 180m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_tags
=== CONT  TestAccRDSEventSubscription_disappears
=== CONT  TestAccRDSEventSubscription_Name_generated
=== CONT  TestAccRDSEventSubscription_sourceIDs
=== CONT  TestAccRDSEventSubscription_namePrefix
=== CONT  TestAccRDSEventSubscription_categories
--- PASS: TestAccRDSEventSubscription_disappears (81.52s)
--- PASS: TestAccRDSEventSubscription_namePrefix (89.18s)
--- PASS: TestAccRDSEventSubscription_Name_generated (89.31s)
--- PASS: TestAccRDSEventSubscription_basic (89.33s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (104.76s)
--- PASS: TestAccRDSEventSubscription_tags (117.32s)
--- PASS: TestAccRDSEventSubscription_categories (179.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	181.962s

ewbankkit · 2021-10-18T14:09:51Z

@kamilturek Thanks for the contribution 🎉 👏.

…es/providerlint/github.com/aws/aws-sdk-go-1.41.4 build(deps): bump github.com/aws/aws-sdk-go from 1.41.2 to 1.41.4 in /providerlint

…m/infrastructure/repository/integrations/github-4.17.0 build(deps): bump integrations/github from 4.16.0 to 4.17.0 in /infrastructure/repository

fix: adjust generators directives with bool flags and add conditional logic for header template

…run-configurations fix: Allow run_configurations to be set on Kinesis AnalyticsV2

provider: cn-northwest-1 (Ningxia) hostedZoneID

…scription_update r/db_event_subscription - fix adding new `event_categories` to existing resource

…dd-setting Add support for additional kinesis_settings to dms_endpoint

github-actions · 2022-05-19T02:37:46Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bambro and others added 6 commits October 15, 2021 09:40

Allow run_configurations to be set for running applications

133068d

adjust directives and add logic where needed to templates

75502a9

Merge branch 'main' into sp-make-gen

ba5dec4

provider: cn-northwest-1 (Ningxia) hostedZoneID

b394587

https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region

Include source type in request if event categories have changed

12a2f8b

Update acceptance tests to avoid regression

3927bb3

kamilturek and others added 18 commits October 17, 2021 22:43

Add changelog

af05c11

include additional kinesis-settings

a5ee635

added the following settings: IncludeTransactionDetails IncludePartitionValue PartitionIncludeSchemaTable IncludeTableAlterOperations IncludeControlDetails IncludeNullAndEmpty

formatting

aa341e1

added schema.Resource

2679b6c

added the new elements to the schema of the Kinesis settings

fix typo

833abac

removed a "}," that should not have been removed :-)

added TestCheckResourceAttr for Kinesis endpoints

22371b2

update fales to "false"

3bb5c26

update documentation

e6fbc35

add changelog

ec3c6af

generalize change log

ff0eed4

Update CHANGELOG entry.

e9dfe40

refactor: apply suggestions from code review

e83a92d

Co-authored-by: Dirk Avery <[email protected]>

fix: update additional test method references

50999f6

Merge branch 'main' into f-kinesis-application-run-configurations

a708ed4

refactor: fix up latest merge

310ad85

ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 18, 2021

ewbankkit added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label Oct 18, 2021

ewbankkit approved these changes Oct 18, 2021

View reviewed changes

ewbankkit and others added 10 commits October 18, 2021 10:12

Simplify comments.

24aed6d

mardown lint

825446e

add comments for new bool template data; add usage for untag bool flag

0b90b1c

Merge pull request hashicorp#21343 from hashicorp/dependabot/go_modul…

6ea4433

…es/providerlint/github.com/aws/aws-sdk-go-1.41.4 build(deps): bump github.com/aws/aws-sdk-go from 1.41.2 to 1.41.4 in /providerlint

Merge pull request hashicorp#21342 from hashicorp/dependabot/terrafor…

ac86cad

…m/infrastructure/repository/integrations/github-4.17.0 build(deps): bump integrations/github from 4.16.0 to 4.17.0 in /infrastructure/repository

Merge pull request hashicorp#21333 from hashicorp/sp-make-gen

34d89a5

fix: adjust generators directives with bool flags and add conditional logic for header template

Merge pull request hashicorp#21303 from bambro/f-kinesis-application-…

3c5c546

…run-configurations fix: Allow run_configurations to be set on Kinesis AnalyticsV2

Merge pull request hashicorp#21337 from PatMyron/patch-1

4a8bb5c

provider: cn-northwest-1 (Ningxia) hostedZoneID

Merge pull request hashicorp#21338 from kamilturek/b-aws_db_event_sub…

df2e0de

…scription_update r/db_event_subscription - fix adding new `event_categories` to existing resource

Merge pull request hashicorp#20084 from ksagle77/f-aws_dms_endpoint-a…

c9bd565

…dd-setting Add support for additional kinesis_settings to dms_endpoint

ewbankkit closed this Oct 18, 2021

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 18, 2021

kamilturek mentioned this pull request Oct 18, 2021

Fail to add new event_categories to an existing aws_db_event_subscription #21319

Closed

kamilturek deleted the b-aws_db_event_subscription_update branch February 11, 2022 16:56

github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/db_event_subscription - fix adding new `event_categories` to existing resource #21338

r/db_event_subscription - fix adding new `event_categories` to existing resource #21338

kamilturek commented Oct 17, 2021

ewbankkit left a comment

ewbankkit commented Oct 18, 2021

github-actions bot commented May 19, 2022

r/db_event_subscription - fix adding new event_categories to existing resource #21338

r/db_event_subscription - fix adding new event_categories to existing resource #21338

Conversation

kamilturek commented Oct 17, 2021

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Oct 18, 2021

github-actions bot commented May 19, 2022

r/db_event_subscription - fix adding new `event_categories` to existing resource #21338

r/db_event_subscription - fix adding new `event_categories` to existing resource #21338