New resource/aws_account_alternate_contact

[shedimon]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21118

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[shedimon]

@ewbankkit @gdavison for some reason my tests are failing locally with a circular dependency I'm struggling to find:

$ make testacc TESTARGS='-run=TestAccAccountAlternateContact'                                                                                                                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact -timeout 180m
# github.com/hashicorp/terraform-provider-aws/internal/service/account
package github.com/hashicorp/terraform-provider-aws/internal/service/account
	imports github.com/hashicorp/terraform-provider-aws/internal/provider
	imports github.com/hashicorp/terraform-provider-aws/internal/acctest: import cycle not allowed in test
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/account [setup failed]

It seems that I'm using the same approach for testing as other services I've checked. Any help appreciated!

[ewbankkit]

@shedimon Thanks for the contribution.
The problem with the circular dependency is resolved by changing the acceptance test files' package to account_test.

To get this merged quickly I went ahead and made that change plus renamed the type argument to alternate_contact_type to match the AWS API.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc PKG_NAME=internal/service/account TESTARGS='-run=TestAccAccountAlternateContact_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact_ -timeout 180m
=== RUN   TestAccAccountAlternateContact_basic
--- PASS: TestAccAccountAlternateContact_basic (27.04s)
=== RUN   TestAccAccountAlternateContact_disappears
--- PASS: TestAccAccountAlternateContact_disappears (11.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	42.243s

GovCloud

% make testacc PKG_NAME=internal/service/account TESTARGS='-run=TestAccAccountAlternateContact_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccountAlternateContact_ -timeout 180m
=== RUN   TestAccAccountAlternateContact_basic
    alternate_contact_test.go:157: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://account.us-gov-west-1.amazonaws.com/getAlternateContact": dial tcp: lookup account.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAccountAlternateContact_basic (27.30s)
=== RUN   TestAccAccountAlternateContact_disappears
    alternate_contact_test.go:157: skipping acceptance testing: RequestError: send request failed
        caused by: Post "https://account.us-gov-west-1.amazonaws.com/getAlternateContact": dial tcp: lookup account.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAccountAlternateContact_disappears (22.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	52.909s

[mforutan]

@shedimon @ewbankkit How about the optional account-id parameter which is needed to use this in an organization account?

[shedimon]

@mforutan To me it looks like two different resources - one to manage alternate contacts in the account it is created in, the other one - via the org main AWS account. That's why I've added only one and left the decision on adding the additional optional parameter/additional resource to the AWS Provider team for further addition following their judgement.

[mforutan]

@shedimon I am not sure what would be the best implementation but following the aws-sdk, I think we should be able to support for both scenarios in this new resource, so I created a new PR: #21888

[github-actions]

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.