Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_shield_protection_health_check_association #21993

Conversation

csabakollar
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19227

Output from acceptance testing:

$ make testacc TESTS='TestAccShieldProtectionHealthCheckAssociation_basic|TestAccShieldProtectionHealthCheckAssociation_disappears' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtectionHealthCheckAssociation_basic|TestAccShieldProtectionHealthCheckAssociation_disappears' -timeout 180m
=== RUN   TestAccShieldProtectionHealthCheckAssociation_basic
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_basic
=== RUN   TestAccShieldProtectionHealthCheckAssociation_disappears
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_disappears
=== CONT  TestAccShieldProtectionHealthCheckAssociation_basic
=== CONT  TestAccShieldProtectionHealthCheckAssociation_disappears
--- PASS: TestAccShieldProtectionHealthCheckAssociation_disappears (36.12s)
--- PASS: TestAccShieldProtectionHealthCheckAssociation_basic (41.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     42.932s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/shield Issues and PRs that pertain to the shield service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 1, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @csabakollar 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTS=TestAccShieldProtectionHealthCheckAssociation_ PKG=shield 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtectionHealthCheckAssociation_' -timeout 180m
=== RUN   TestAccShieldProtectionHealthCheckAssociation_basic
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_basic
=== RUN   TestAccShieldProtectionHealthCheckAssociation_disappears
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_disappears
=== CONT  TestAccShieldProtectionHealthCheckAssociation_basic
=== CONT  TestAccShieldProtectionHealthCheckAssociation_disappears
--- PASS: TestAccShieldProtectionHealthCheckAssociation_disappears (18.39s)
--- PASS: TestAccShieldProtectionHealthCheckAssociation_basic (20.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	24.249s
GovCloud
% make testacc TESTS=TestAccShieldProtectionHealthCheckAssociation_ PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProtectionHealthCheckAssociation_' -timeout 180m
=== RUN   TestAccShieldProtectionHealthCheckAssociation_basic
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_basic
=== RUN   TestAccShieldProtectionHealthCheckAssociation_disappears
=== PAUSE TestAccShieldProtectionHealthCheckAssociation_disappears
=== CONT  TestAccShieldProtectionHealthCheckAssociation_basic
=== CONT  TestAccShieldProtectionHealthCheckAssociation_disappears
=== CONT  TestAccShieldProtectionHealthCheckAssociation_basic
    acctest.go:608: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccShieldProtectionHealthCheckAssociation_basic (1.34s)
=== CONT  TestAccShieldProtectionHealthCheckAssociation_disappears
    acctest.go:608: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccShieldProtectionHealthCheckAssociation_disappears (1.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	4.460s

@ewbankkit
Copy link
Contributor

@csabakollar Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d5449ef into hashicorp:main Jan 12, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New resource: shield_protection_health_check_association
3 participants